Bug 158226 - [Mac] AirPlay route is sometimes reset when changing video.src
Summary: [Mac] AirPlay route is sometimes reset when changing video.src
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-05-31 08:17 PDT by Eric Carlson
Modified: 2016-06-19 17:52 PDT (History)
5 users (show)

See Also:

Attachments
Proposed patch. (5.91 KB, patch)
2016-05-31 08:40 PDT, Eric Carlson 		buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews102 for mac-yosemite (803.74 KB, application/zip)
2016-05-31 09:27 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews105 for mac-yosemite-wk2 (998.24 KB, application/zip)
2016-05-31 09:30 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews113 for mac-yosemite (1.41 MB, application/zip)
2016-05-31 09:38 PDT, Build Bot 		no flags Details
Updated Patch. (6.55 KB, patch)
2016-05-31 10:05 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2016-05-31 08:17:23 PDT 
Remove the AirPlay user gesture requirement if webkitShowPlaybackTargetPicker is called from a user gesture event handler.
Comment 1 Eric Carlson 2016-05-31 08:23:38 PDT 
<rdar://problem/24197592>
Comment 2 Eric Carlson 2016-05-31 08:40:43 PDT 
Created attachment 280146 [details]
Proposed patch.
Comment 3 Build Bot 2016-05-31 09:27:24 PDT 
Comment on attachment 280146 [details]
Proposed patch.

Attachment 280146 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1413001

New failing tests:
media/airplay-autoplay.html
Comment 4 Build Bot 2016-05-31 09:27:26 PDT 
Created attachment 280149 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 5 Build Bot 2016-05-31 09:30:06 PDT 
Comment on attachment 280146 [details]
Proposed patch.

Attachment 280146 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1413014

New failing tests:
media/airplay-autoplay.html
Comment 6 Build Bot 2016-05-31 09:30:09 PDT 
Created attachment 280150 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 7 Build Bot 2016-05-31 09:38:40 PDT 
Comment on attachment 280146 [details]
Proposed patch.

Attachment 280146 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1413026

New failing tests:
media/airplay-autoplay.html
Comment 8 Build Bot 2016-05-31 09:38:43 PDT 
Created attachment 280152 [details]
Archive of layout-test-results from ews113 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 9 Eric Carlson 2016-05-31 10:05:16 PDT 
Created attachment 280154 [details]
Updated Patch.

Skip the new test on Yosemite where AirPlay isn't supported.
Comment 10 WebKit Commit Bot 2016-05-31 13:46:36 PDT 
Comment on attachment 280154 [details]
Updated Patch.

Clearing flags on attachment: 280154

Committed r201522: <http://trac.webkit.org/changeset/201522>
Comment 11 WebKit Commit Bot 2016-05-31 13:46:40 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 12 Michael Catanzaro 2016-06-19 17:52:26 PDT 
This test is timing out on GTK, see bug #158923.