Bug 158225 - [Win] Potential null pointer crash when setting cursor.
Summary: [Win] Potential null pointer crash when setting cursor.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-31 05:23 PDT by Per Arne Vollan
Modified: 2016-06-01 02:15 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.21 KB, patch)
2016-05-31 05:32 PDT, Per Arne Vollan 		achristensen: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2016-05-31 05:23:39 PDT 
Code inspection shows that the call cursor.platformCursor() can return null.

void WebChromeClient::setCursor(const Cursor& cursor)
{
    HCURSOR platformCursor = cursor.platformCursor()->nativeCursor();
    ...
Comment 1 Per Arne Vollan 2016-05-31 05:32:42 PDT 
Created attachment 280139 [details]
Patch
Comment 2 Alex Christensen 2016-05-31 09:52:35 PDT 
Comment on attachment 280139 [details]
Patch

Sure
Comment 3 Per Arne Vollan 2016-06-01 02:13:50 PDT 
(In reply to comment #2)
> Comment on attachment 280139 [details]
> Patch
> 
> Sure

Thanks for reviewing :)
Comment 4 Per Arne Vollan 2016-06-01 02:15:08 PDT 
Committed r201546: <https://trac.webkit.org/changeset/201546>