Bug 158213 - Web Inspector: Filter Records not applying to new records
Summary: Web Inspector: Filter Records not applying to new records
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Local Build
Hardware: All All
: P2 Normal
Assignee: Matt Baker
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-05-30 13:12 PDT by Saam Barati
Modified: 2016-06-13 15:42 PDT (History)
8 users (show)

See Also:

Attachments
[Patch] Proposed Fix (7.20 KB, patch)
2016-06-11 16:52 PDT, Matt Baker 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2016-05-30 13:12:43 PDT 
Repro steps:
1. Start recording this page: http://bl.ocks.org/syntagmatic/6c149c08fc9cde682635
2. Stop recording
3. Click on Javascript & events
4. Filter records by the string "Garbage Collection"
5. Notice you only see Garbage Collection events
6. Continue the recording
7. stop the recording
8. We now have records that aren't just "Garbage Collection" records
Comment 1 Radar WebKit Bug Importer 2016-05-30 13:12:59 PDT 
<rdar://problem/26543912>
Comment 2 BJ Burg 2016-05-30 13:16:51 PDT 
The filter is also not re-applied when switching between timelines.
Comment 3 Matt Baker 2016-06-08 14:54:56 PDT 
I can only reproduce this when the the second part of the recording falls outside the ruler selection end time. This makes sense, because TimelineView won't call _timesDidChange (which causes filters to update) when the current time marker falls outside the ruler selection.
Comment 4 Matt Baker 2016-06-11 16:52:05 PDT 
Created attachment 281114 [details]
[Patch] Proposed Fix
Comment 5 WebKit Commit Bot 2016-06-13 15:42:50 PDT 
Comment on attachment 281114 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 281114

Committed r202011: <http://trac.webkit.org/changeset/202011>
Comment 6 WebKit Commit Bot 2016-06-13 15:42:53 PDT 
All reviewed patches have been landed.  Closing bug.