RESOLVED FIXED 158213
Web Inspector: Filter Records not applying to new records 
https://bugs.webkit.org/show_bug.cgi?id=158213
Summary Web Inspector: Filter Records not applying to new records
Saam Barati
Reported 2016-05-30 13:12:43 PDT
Repro steps: 1. Start recording this page: http://bl.ocks.org/syntagmatic/6c149c08fc9cde682635 2. Stop recording 3. Click on Javascript & events 4. Filter records by the string "Garbage Collection" 5. Notice you only see Garbage Collection events 6. Continue the recording 7. stop the recording 8. We now have records that aren't just "Garbage Collection" records
Attachments
[Patch] Proposed Fix (7.20 KB, patch)
2016-06-11 16:52 PDT, Matt Baker 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-05-30 13:12:59 PDT
<rdar://problem/26543912>
Blaze Burg
Comment 2 2016-05-30 13:16:51 PDT
The filter is also not re-applied when switching between timelines.
Matt Baker
Comment 3 2016-06-08 14:54:56 PDT
I can only reproduce this when the the second part of the recording falls outside the ruler selection end time. This makes sense, because TimelineView won't call _timesDidChange (which causes filters to update) when the current time marker falls outside the ruler selection.
Matt Baker
Comment 4 2016-06-11 16:52:05 PDT
Created attachment 281114 [details] [Patch] Proposed Fix
WebKit Commit Bot
Comment 5 2016-06-13 15:42:50 PDT
Comment on attachment 281114 [details] [Patch] Proposed Fix Clearing flags on attachment: 281114 Committed r202011: <http://trac.webkit.org/changeset/202011>
WebKit Commit Bot
Comment 6 2016-06-13 15:42:53 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.