Bug 158200 - [GTK] Test /webkit2/WebKitWebView/geolocation-permission-requests is failing since r201423
Summary: [GTK] Test /webkit2/WebKitWebView/geolocation-permission-requests is failing ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2016-05-30 06:11 PDT by Carlos Garcia Campos
Modified: 2016-05-31 00:21 PDT (History)
3 users (show)

See Also:


Attachments
Patch (6.20 KB, patch)
2016-05-30 06:15 PDT, Carlos Garcia Campos
no flags Details | Formatted Diff | Diff
Fix coding style (6.20 KB, patch)
2016-05-30 06:23 PDT, Carlos Garcia Campos
pnormand: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2016-05-30 06:11:05 PDT
/webkit2/WebKitWebView/geolocation-permission-requests:              **

ERROR:../../Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:741:void testWebViewGeolocationPermissionRequests(UIClientTest*, gconstpointer): assertion failed (result == "1"): ("2" == "1")

FAIL

This is because geolocation is no longer allowed for non secure sites, like HTTP. In that case POSITION_UNAVAILABLE ('2') is returned without asking the API layer. We need to update the test to not use HTTP, or even better keep the HTTP case to check that it's indeed returning POSITION_UNAVAILABLE.
Comment 1 Carlos Garcia Campos 2016-05-30 06:15:27 PDT
Created attachment 280090 [details]
Patch
Comment 2 WebKit Commit Bot 2016-05-30 06:16:31 PDT
Attachment 280090 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:285:  Declaration has space between type name and * in const char *waitUntilPermissionResultMessageReceived  [whitespace/declaration] [3]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Carlos Garcia Campos 2016-05-30 06:23:58 PDT
Created attachment 280094 [details]
Fix coding style
Comment 4 Carlos Garcia Campos 2016-05-31 00:21:36 PDT
Committed r201505: <http://trac.webkit.org/changeset/201505>