Bug 158197 - [css-grid] Positioned items can be placed on the implicit grid
Summary: [css-grid] Positioned items can be placed on the implicit grid
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Manuel Rego Casasnovas
URL:
Keywords: BlinkMergeCandidate
Depends on: 155197
Blocks: 60731
  Show dependency treegraph
 
Reported: 2016-05-30 00:11 PDT by Manuel Rego Casasnovas
Modified: 2016-06-01 00:23 PDT (History)
10 users (show)

See Also:


Attachments
Patch (9.84 KB, patch)
2016-05-30 00:15 PDT, Manuel Rego Casasnovas
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews100 for mac-yosemite (803.74 KB, application/zip)
2016-05-30 01:01 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews107 for mac-yosemite-wk2 (841.34 KB, application/zip)
2016-05-30 01:05 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews123 for ios-simulator-wk2 (665.38 KB, application/zip)
2016-05-30 01:09 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews115 for mac-yosemite (1.42 MB, application/zip)
2016-05-30 01:15 PDT, Build Bot
no flags Details
Patch (9.84 KB, patch)
2016-05-30 01:19 PDT, Manuel Rego Casasnovas
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Manuel Rego Casasnovas 2016-05-30 00:11:52 PDT
It should be possible to place positioned items on the implicit grid.
Right now the code doesn't allow it, but the spec doesn't say anything.

More info: https://blogs.igalia.com/mrego/2016/05/27/css-grid-layout-and-positioned-items/#positioned-items-and-implicit-grid

Blink patch: https://codereview.chromium.org/2021683002/
Comment 1 Manuel Rego Casasnovas 2016-05-30 00:15:06 PDT
Created attachment 280074 [details]
Patch

fast/css-grid-layout/grid-positioned-items-implicit-grid.html test will be failing until patch for bug #155197 lands.
Comment 2 Sergio Villar Senin 2016-05-30 00:35:27 PDT
Comment on attachment 280074 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=280074&action=review

Yes.

> Source/WebCore/ChangeLog:10
> +        However, the spec doesn't mention anything about this.

Nit, use the same paragraph.
Comment 3 Build Bot 2016-05-30 01:01:18 PDT
Comment on attachment 280074 [details]
Patch

Attachment 280074 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1406005

New failing tests:
fast/css-grid-layout/grid-positioned-items-implicit-grid.html
Comment 4 Build Bot 2016-05-30 01:01:21 PDT
Created attachment 280078 [details]
Archive of layout-test-results from ews100 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 5 Build Bot 2016-05-30 01:05:20 PDT
Comment on attachment 280074 [details]
Patch

Attachment 280074 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1406006

New failing tests:
fast/css-grid-layout/grid-positioned-items-implicit-grid.html
Comment 6 Build Bot 2016-05-30 01:05:23 PDT
Created attachment 280079 [details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 7 Build Bot 2016-05-30 01:09:12 PDT
Comment on attachment 280074 [details]
Patch

Attachment 280074 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1406007

New failing tests:
fast/css-grid-layout/grid-positioned-items-implicit-grid.html
Comment 8 Build Bot 2016-05-30 01:09:16 PDT
Created attachment 280080 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.4
Comment 9 Build Bot 2016-05-30 01:15:53 PDT
Comment on attachment 280074 [details]
Patch

Attachment 280074 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1406025

New failing tests:
fast/css-grid-layout/grid-positioned-items-implicit-grid.html
Comment 10 Build Bot 2016-05-30 01:15:56 PDT
Created attachment 280081 [details]
Archive of layout-test-results from ews115 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 11 Manuel Rego Casasnovas 2016-05-30 01:19:26 PDT
Created attachment 280082 [details]
Patch

Thanks for the review, anyway it needs to wait for bug #155197 to land first.
Comment 12 WebKit Commit Bot 2016-06-01 00:23:03 PDT
Comment on attachment 280082 [details]
Patch

Clearing flags on attachment: 280082

Committed r201545: <http://trac.webkit.org/changeset/201545>
Comment 13 WebKit Commit Bot 2016-06-01 00:23:09 PDT
All reviewed patches have been landed.  Closing bug.