Bug 158197 – [css-grid] Positioned items can be placed on the implicit grid

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Manuel Rego Casasnovas]

It should be possible to place positioned items on the implicit grid.
Right now the code doesn't allow it, but the spec doesn't say anything.

More info: https://blogs.igalia.com/mrego/2016/05/27/css-grid-layout-and-positioned-items/#positioned-items-and-implicit-grid

Blink patch: https://codereview.chromium.org/2021683002/

[Manuel Rego Casasnovas]

Created attachment 280074 [details]
Patch

fast/css-grid-layout/grid-positioned-items-implicit-grid.html test will be failing until patch for bug #155197 lands.

[Sergio Villar Senin]

Comment on attachment 280074 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=280074&action=review

Yes.

> Source/WebCore/ChangeLog:10
> +        However, the spec doesn't mention anything about this.

Nit, use the same paragraph.

[Build Bot]

Comment on attachment 280074 [details]
Patch

Attachment 280074 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1406005

New failing tests:
fast/css-grid-layout/grid-positioned-items-implicit-grid.html

[Build Bot]

Created attachment 280078 [details]
Archive of layout-test-results from ews100 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 280074 [details]
Patch

Attachment 280074 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1406006

New failing tests:
fast/css-grid-layout/grid-positioned-items-implicit-grid.html

[Build Bot]

Created attachment 280079 [details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 280074 [details]
Patch

Attachment 280074 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1406007

New failing tests:
fast/css-grid-layout/grid-positioned-items-implicit-grid.html

[Build Bot]

Created attachment 280080 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.4

[Build Bot]

Comment on attachment 280074 [details]
Patch

Attachment 280074 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1406025

New failing tests:
fast/css-grid-layout/grid-positioned-items-implicit-grid.html

[Build Bot]

Created attachment 280081 [details]
Archive of layout-test-results from ews115 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Manuel Rego Casasnovas]

Created attachment 280082 [details]
Patch

Thanks for the review, anyway it needs to wait for bug #155197 to land first.

[WebKit Commit Bot]

Comment on attachment 280082 [details]
Patch

Clearing flags on attachment: 280082

Committed r201545: <http://trac.webkit.org/changeset/201545>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.