Bug 158186 - JSGlobalLexicalEnvironment leaks SegmentedVector due to lack of destructor.
Summary: JSGlobalLexicalEnvironment leaks SegmentedVector due to lack of destructor.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords: Performance
Depends on:
Blocks:
 
Reported: 2016-05-28 18:56 PDT by Andreas Kling
Modified: 2016-05-28 21:46 PDT (History)
6 users (show)

See Also:

Attachments
Proposed patch (3.07 KB, patch)
2016-05-28 18:57 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2016-05-28 18:56:41 PDT 
We're leaking all of the SegmentedVector backing stores from JSGlobalLexicalEnvironment since it doesn't get a destructor call.
Comment 1 Andreas Kling 2016-05-28 18:57:33 PDT 
Created attachment 280053 [details]
Proposed patch
Comment 2 Saam Barati 2016-05-28 20:23:36 PDT 
Comment on attachment 280053 [details]
Proposed patch

r=me
Nice catch
Comment 3 WebKit Commit Bot 2016-05-28 21:46:27 PDT 
Comment on attachment 280053 [details]
Proposed patch

Clearing flags on attachment: 280053

Committed r201494: <http://trac.webkit.org/changeset/201494>
Comment 4 WebKit Commit Bot 2016-05-28 21:46:31 PDT 
All reviewed patches have been landed.  Closing bug.