Bug 158176 - Improve lambda capture in NetworkCache::Storage::synchronize()
Summary: Improve lambda capture in NetworkCache::Storage::synchronize()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on: 158111
Blocks:
  Show dependency tree / graph
 
Reported: 2016-05-27 20:40 PDT by Chris Dumez
Modified: 2016-05-27 21:48 PDT (History)
6 users (show)

See Also:

Attachments
Patch (2.19 KB, patch)
2016-05-27 20:43 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-05-27 20:40:48 PDT 
Improve lambda capture in NetworkCache::Storage::synchronize() by leveraging C++14's capture with initializer.
Comment 1 Chris Dumez 2016-05-27 20:43:32 PDT 
Created attachment 280018 [details]
Patch
Comment 2 Brady Eidson 2016-05-27 21:42:50 PDT 
Comment on attachment 280018 [details]
Patch

Is capturing a protectedThis not necessary?

I'm not sure, as I didn't look, but please confirm by yourself :)
Comment 3 Chris Dumez 2016-05-27 21:47:39 PDT 
Comment on attachment 280018 [details]
Patch

Clearing flags on attachment: 280018

Committed r201480: <http://trac.webkit.org/changeset/201480>
Comment 4 Chris Dumez 2016-05-27 21:47:47 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Chris Dumez 2016-05-27 21:48:19 PDT 
(In reply to comment #2)
> Comment on attachment 280018 [details]
> Patch
> 
> Is capturing a protectedThis not necessary?
> 
> I'm not sure, as I didn't look, but please confirm by yourself :)

No need, NetworkCacheStorage is owned by the NetworkCache, which is a singleton.