RESOLVED FIXED 158169
Use COMPILER(MSVC) instead of PLATFORM(WIN) for MSVC-specific workaround 
https://bugs.webkit.org/show_bug.cgi?id=158169
Summary Use COMPILER(MSVC) instead of PLATFORM(WIN) for MSVC-specific workaround
Konstantin Tokarev
Reported 2016-05-27 14:58:18 PDT
Use COMPILER(MSVC) instead of PLATFORM(WIN) for MSVC-specific workaround.
Attachments
Patch (2.47 KB, patch)
2016-05-27 15:04 PDT, Konstantin Tokarev 		no flags
DetailsFormatted DiffDiff
Patch (2.49 KB, patch)
2016-05-27 16:04 PDT, Konstantin Tokarev 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Konstantin Tokarev
Comment 1 2016-05-27 15:04:40 PDT
Created attachment 279999 [details] Patch
Darin Adler
Comment 2 2016-05-27 16:02:31 PDT
Comment on attachment 279999 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=279999&action=review > Source/WebCore/platform/PlatformMouseEvent.h:152 > + bool operator==(unsigned short a, MouseButton b) > + { > + return a == static_cast<unsigned short>(b); > + } > + > + bool operator!=(unsigned short a, MouseButton b) > + { > + return a != static_cast<unsigned short>(b); > + } These will need to be marked inline or we can get linker errors.
Konstantin Tokarev
Comment 3 2016-05-27 16:04:15 PDT
Created attachment 280008 [details] Patch
Darin Adler
Comment 4 2016-05-28 09:37:55 PDT
Comment on attachment 280008 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=280008&action=review > Source/WebCore/platform/PlatformMouseEvent.h:142 > // These methods are necessary to work around the fact that MSVC will not find a most-specific I would have said "functions", not "methods".
Konstantin Tokarev
Comment 5 2016-05-28 09:55:20 PDT
Manually committed https://trac.webkit.org/r201485, addressing your comment.
Note You need to log in before you can comment on or make changes to this bug.