Bug 158162 – Web Inspector: Timelines: "-0.000ms" in Self Time

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Nikita Vasilyev]

Via https://bugs.webkit.org/show_bug.cgi?id=158117#c8

We should never show "-0.000ms".
It should be "0ms".

[Radar WebKit Bug Importer]

<rdar://problem/26523350>

[Blaze Burg]

Do we have steps to reproduce this? A reduction?

[Blaze Burg]

I found several of these frames when profiling http://discuss.emberjs.com/.

STEPS TO REPRODUCE

1. Start timeline recording on the page
2. Reload the page
3. Go to "Events" view in JavaScript timeline view
4. Expand the subtree for the DOMContentLoaded event

Several of the nodes seem to have -0.000 or -0.00001 self time.

[Blaze Burg]

Created attachment 280111 [details]
Proposed Fix

[Darin Adler]

Comment on attachment 280111 [details]
Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=280111&action=review

> Source/WebInspectorUI/UserInterface/Models/ProfileNode.js:164
> +                if (this._selfTime < 0.0001)
> +                    this._selfTime = 0.0;

This is OK, but what about normal rounding to a certain number of decimal places? Once we start doing that we might not need this any more.

[Darin Adler]

Comment on attachment 280111 [details]
Proposed Fix

I’m going to say review+ even though I would prefer code that rounds instead of code that adds a special case just for close-to-zero and negative.

[WebKit Commit Bot]

Comment on attachment 280111 [details]
Proposed Fix

Clearing flags on attachment: 280111

Committed r201503: <http://trac.webkit.org/changeset/201503>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.