Bug 158161 - Fix the build with newer clang and other custom configuration options
Summary: Fix the build with newer clang and other custom configuration options
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-27 12:48 PDT by Alexey Proskuryakov
Modified: 2016-05-28 16:15 PDT (History)
4 users (show)

See Also:

Attachments
proposed fix (7.58 KB, patch)
2016-05-27 12:58 PDT, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
with a pragma (6.55 KB, patch)
2016-05-27 15:36 PDT, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
proposed fix (6.88 KB, patch)
2016-05-27 16:26 PDT, Alexey Proskuryakov 		mitz: review+
Details | Formatted Diff | Diff
patch for landing (6.87 KB, patch)
2016-05-28 13:37 PDT, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2016-05-27 12:48:37 PDT 
Fix the build with newer clang and other custom configuration options.
Comment 1 Alexey Proskuryakov 2016-05-27 12:58:06 PDT 
Created attachment 279984 [details]
proposed fix
Comment 2 WebKit Commit Bot 2016-05-27 13:00:47 PDT 
Attachment 279984 [details] did not pass style-queue:


ERROR: Source/WebKit2/Shared/mac/CookieStorageShimLibrary.cpp:85:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 mitz 2016-05-27 13:01:31 PDT 
Anders suggested marking *SPI.h headers as system headers using a pragma. I think we should do that instead of suppressing individual warning in them.
Comment 4 Alexey Proskuryakov 2016-05-27 13:10:29 PDT 
Seems reasonable. How does one do that?

I don't remember if we ever had any useful warnings in SPI headers, although I'm also not sure whether I would remember if we did.
Comment 5 mitz 2016-05-27 13:32:24 PDT 
(In reply to comment #4)
> Seems reasonable. How does one do that?

#pragma clang system_header
Comment 6 Alexey Proskuryakov 2016-05-27 15:36:20 PDT 
Created attachment 280003 [details]
with a pragma
Comment 7 WebKit Commit Bot 2016-05-27 15:39:25 PDT 
Attachment 280003 [details] did not pass style-queue:


ERROR: Source/WebKit2/Shared/mac/CookieStorageShimLibrary.cpp:85:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Alexey Proskuryakov 2016-05-27 16:26:20 PDT 
Created attachment 280011 [details]
proposed fix

Reverted too much when changing CFNetworkSPI.h.
Comment 9 WebKit Commit Bot 2016-05-27 16:28:47 PDT 
Attachment 280011 [details] did not pass style-queue:


ERROR: Source/WebKit2/Shared/mac/CookieStorageShimLibrary.cpp:85:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 10 mitz 2016-05-27 21:55:53 PDT 
Comment on attachment 280011 [details]
proposed fix

View in context: https://bugs.webkit.org/attachment.cgi?id=280011&action=review

> Source/WebCore/platform/spi/mac/AVFoundationSPI.h:68
> +@interface AVAssetCache (Details)

We have stopped using categories for this, instead using class extensions, like in CFNetworkSPI.h above.

> Source/WebKit2/ChangeLog:9
> +        * NetworkProcess/ios/NetworkProcessIOS.mm: -setAllowsSpecificHTTPSCertificate:forHost:
> +        is not in CFNetworkSPI.h

“not”?
Comment 11 Alexey Proskuryakov 2016-05-28 13:37:24 PDT 
Created attachment 280047 [details]
patch for landing
Comment 12 WebKit Commit Bot 2016-05-28 13:40:31 PDT 
Attachment 280047 [details] did not pass style-queue:


ERROR: Source/WebKit2/Shared/mac/CookieStorageShimLibrary.cpp:85:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 13 WebKit Commit Bot 2016-05-28 16:15:37 PDT 
Comment on attachment 280047 [details]
patch for landing

Clearing flags on attachment: 280047

Committed r201492: <http://trac.webkit.org/changeset/201492>
Comment 14 WebKit Commit Bot 2016-05-28 16:15:41 PDT 
All reviewed patches have been landed.  Closing bug.