Bug 158161 – Fix the build with newer clang and other custom configuration options

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Alexey Proskuryakov]

Fix the build with newer clang and other custom configuration options.

[Alexey Proskuryakov]

Created attachment 279984 [details]
proposed fix

[WebKit Commit Bot]

Attachment 279984 [details] did not pass style-queue:


ERROR: Source/WebKit2/Shared/mac/CookieStorageShimLibrary.cpp:85:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Anders suggested marking *SPI.h headers as system headers using a pragma. I think we should do that instead of suppressing individual warning in them.

[Alexey Proskuryakov]

Seems reasonable. How does one do that?

I don't remember if we ever had any useful warnings in SPI headers, although I'm also not sure whether I would remember if we did.

(In reply to comment #4)
> Seems reasonable. How does one do that?

#pragma clang system_header

[Alexey Proskuryakov]

Created attachment 280003 [details]
with a pragma

[WebKit Commit Bot]

Attachment 280003 [details] did not pass style-queue:


ERROR: Source/WebKit2/Shared/mac/CookieStorageShimLibrary.cpp:85:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alexey Proskuryakov]

Created attachment 280011 [details]
proposed fix

Reverted too much when changing CFNetworkSPI.h.

[WebKit Commit Bot]

Attachment 280011 [details] did not pass style-queue:


ERROR: Source/WebKit2/Shared/mac/CookieStorageShimLibrary.cpp:85:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment on attachment 280011 [details]
proposed fix

View in context: https://bugs.webkit.org/attachment.cgi?id=280011&action=review

> Source/WebCore/platform/spi/mac/AVFoundationSPI.h:68
> +@interface AVAssetCache (Details)

We have stopped using categories for this, instead using class extensions, like in CFNetworkSPI.h above.

> Source/WebKit2/ChangeLog:9
> +        * NetworkProcess/ios/NetworkProcessIOS.mm: -setAllowsSpecificHTTPSCertificate:forHost:
> +        is not in CFNetworkSPI.h

“not”?

[Alexey Proskuryakov]

Created attachment 280047 [details]
patch for landing

[WebKit Commit Bot]

Attachment 280047 [details] did not pass style-queue:


ERROR: Source/WebKit2/Shared/mac/CookieStorageShimLibrary.cpp:85:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 280047 [details]
patch for landing

Clearing flags on attachment: 280047

Committed r201492: <http://trac.webkit.org/changeset/201492>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.