Bug 158155 - Regression(r200972): Webcore::Range::collectSelectionsRects() asserts in startContainer() while selecting text.
Summary: Regression(r200972): Webcore::Range::collectSelectionsRects() asserts in star...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks: 157681
  Show dependency treegraph
 
Reported: 2016-05-27 09:46 PDT by zalan
Modified: 2016-05-27 10:08 PDT (History)
3 users (show)

See Also:


Attachments
Patch (2.14 KB, patch)
2016-05-27 09:56 PDT, zalan
cdumez: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2016-05-27 09:46:45 PDT
1. Load j-archive.com
2. Start selecting text.
-> assert()
Comment 1 zalan 2016-05-27 09:47:53 PDT
rdar://problem/26502712
Comment 2 zalan 2016-05-27 09:56:46 PDT
Created attachment 279966 [details]
Patch
Comment 3 Chris Dumez 2016-05-27 09:59:49 PDT
Comment on attachment 279966 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=279966&action=review

r=me

> Source/WebKit2/ChangeLog:3
> +        Webcore::Range::collectSelectionsRects() asserts in startContainer() while selecting text.

I think we should indicate which revision regressed it in the title (since we know and it is recent).

> Source/WebKit2/ChangeLog:10
> +        * WebProcess/WebPage/ios/WebPageIOS.mm:

I understand we need to land this quickly but we really need to land a test case in a follow-up.
Comment 4 zalan 2016-05-27 10:08:06 PDT
Committed r201453: <http://trac.webkit.org/changeset/201453>