Bug 158152 - AX: [ATK] accessibility/gtk/no-notification-for-unrendered-iframe-children.html began failing after r201416
Summary: AX: [ATK] accessibility/gtk/no-notification-for-unrendered-iframe-children.ht...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Linux
: P2 Normal
Assignee: Joanmarie Diggs
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-05-27 05:02 PDT by Joanmarie Diggs
Modified: 2016-05-27 12:07 PDT (History)
9 users (show)

See Also:

Attachments
Patch (5.40 KB, patch)
2016-05-27 10:20 PDT, Joanmarie Diggs 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joanmarie Diggs 2016-05-27 05:02:29 PDT 
Looking at the "failure," it may actually be a "fix" because from a quick glance only one child is being added; not two.

I should have some time today to verify this and update the expectations (or debug the failure). Deliberately not skipping the test for now.
Comment 1 Radar WebKit Bug Importer 2016-05-27 05:03:03 PDT 
<rdar://problem/26515630>
Comment 2 Joanmarie Diggs 2016-05-27 10:20:15 PDT 
Created attachment 279969 [details]
Patch
Comment 3 Joanmarie Diggs 2016-05-27 10:23:49 PDT 
Chris: Should be a super-quick review. Rather than just rebaseline the test, I started including the child being added/removed in the data sent to the listener so we can verify we're getting what we assume we're getting.

Thanks!
Comment 4 WebKit Commit Bot 2016-05-27 12:07:20 PDT 
Comment on attachment 279969 [details]
Patch

Clearing flags on attachment: 279969

Committed r201458: <http://trac.webkit.org/changeset/201458>
Comment 5 WebKit Commit Bot 2016-05-27 12:07:25 PDT 
All reviewed patches have been landed.  Closing bug.