Bug 158146 – Video play glyph not visible if initially invisible when contained in a "-webkit-overflow-scrolling: touch" container

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Antoine Quint]

<rdar://problem/25816307>

[Antoine Quint]

Created attachment 279946 [details]
Reduction

[Radar WebKit Bug Importer]

<rdar://problem/26513556>

[Radar WebKit Bug Importer]

<rdar://problem/26513543>

[Antoine Quint]

If a <video> on iOS is contained within a "-webkit-overflow-scrolling: touch" container  and is laid out such that its play button is not initially visible, the play glyph will be invisible until it's touched or a layout happens. The root of this issue is https://bugs.webkit.org/show_bug.cgi?id=158147, but this is tracking an ad-hoc fix to just the video controls.

[Antoine Quint]

Created attachment 279948 [details]
Patch

[Antoine Quint]

Ideally the test would dump the layers in the shadow tree as well but I'm not sure if that's possible.

[Dean Jackson]

Comment on attachment 279948 [details]
Patch

why don't you use a compositing test? that will show the layers.

[Antoine Quint]

Created attachment 279955 [details]
Patch for landing

[Antoine Quint]

(In reply to comment #7)
> Comment on attachment 279948 [details]
> Patch
> 
> why don't you use a compositing test? that will show the layers.

Didn't really know about that ability, which is exactly what I needed. Updated the test to dump the layer tree when landing, it fails without this fix.

[WebKit Commit Bot]

Comment on attachment 279955 [details]
Patch for landing

Clearing flags on attachment: 279955

Committed r201450: <http://trac.webkit.org/changeset/201450>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.