Bug 158146 - Video play glyph not visible if initially invisible when contained in a "-webkit-overflow-scrolling: touch" container
Summary: Video play glyph not visible if initially invisible when contained in a "-web...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: iPhone / iPad iOS 9.3
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on: 158147
Blocks:
  Show dependency tree / graph
 
Reported: 2016-05-27 01:04 PDT by Antoine Quint
Modified: 2016-05-27 06:49 PDT (History)
3 users (show)

See Also:

Attachments
Reduction (473 bytes, text/html)
2016-05-27 01:05 PDT, Antoine Quint 		no flags Details
Patch (5.19 KB, patch)
2016-05-27 01:20 PDT, Antoine Quint 		no flags Details | Formatted Diff | Diff
Patch for landing (6.39 KB, patch)
2016-05-27 06:20 PDT, Antoine Quint 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2016-05-27 01:04:44 PDT 
<rdar://problem/25816307>
Comment 1 Antoine Quint 2016-05-27 01:05:47 PDT 
Created attachment 279946 [details]
Reduction
Comment 2 Radar WebKit Bug Importer 2016-05-27 01:06:44 PDT 
<rdar://problem/26513556>
Comment 3 Radar WebKit Bug Importer 2016-05-27 01:06:49 PDT 
<rdar://problem/26513543>
Comment 4 Antoine Quint 2016-05-27 01:15:39 PDT 
If a <video> on iOS is contained within a "-webkit-overflow-scrolling: touch" container  and is laid out such that its play button is not initially visible, the play glyph will be invisible until it's touched or a layout happens. The root of this issue is https://bugs.webkit.org/show_bug.cgi?id=158147, but this is tracking an ad-hoc fix to just the video controls.
Comment 5 Antoine Quint 2016-05-27 01:20:56 PDT 
Created attachment 279948 [details]
Patch
Comment 6 Antoine Quint 2016-05-27 01:33:10 PDT 
Ideally the test would dump the layers in the shadow tree as well but I'm not sure if that's possible.
Comment 7 Dean Jackson 2016-05-27 04:59:56 PDT 
Comment on attachment 279948 [details]
Patch

why don't you use a compositing test? that will show the layers.
Comment 8 Antoine Quint 2016-05-27 06:20:59 PDT 
Created attachment 279955 [details]
Patch for landing
Comment 9 Antoine Quint 2016-05-27 06:25:44 PDT 
(In reply to comment #7)
> Comment on attachment 279948 [details]
> Patch
> 
> why don't you use a compositing test? that will show the layers.

Didn't really know about that ability, which is exactly what I needed. Updated the test to dump the layer tree when landing, it fails without this fix.
Comment 10 WebKit Commit Bot 2016-05-27 06:49:51 PDT 
Comment on attachment 279955 [details]
Patch for landing

Clearing flags on attachment: 279955

Committed r201450: <http://trac.webkit.org/changeset/201450>
Comment 11 WebKit Commit Bot 2016-05-27 06:49:55 PDT 
All reviewed patches have been landed.  Closing bug.