Bug 158129 - Use std::atomic<> rather than OSAtomicIncrement in CARingBuffer.cpp
Summary: Use std::atomic<> rather than OSAtomicIncrement in CARingBuffer.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-26 12:09 PDT by Jer Noble
Modified: 2016-05-26 14:56 PDT (History)
2 users (show)

See Also:

Attachments
Patch (3.68 KB, patch)
2016-05-26 12:13 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2016-05-26 12:09:55 PDT 
Use std::atomic<> rather than OSAtomicIncrement in CARingBuffer.cpp
Comment 1 Jer Noble 2016-05-26 12:13:41 PDT 
Created attachment 279903 [details]
Patch
Comment 2 Eric Carlson 2016-05-26 12:44:32 PDT 
Comment on attachment 279903 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=279903&action=review

> Source/WebCore/platform/audio/mac/CARingBuffer.h:88
> +    std::atomic<int32_t> m_timeBoundsQueuePtr;

Should this be unsigned?
Comment 3 WebKit Commit Bot 2016-05-26 14:56:48 PDT 
Comment on attachment 279903 [details]
Patch

Clearing flags on attachment: 279903

Committed r201432: <http://trac.webkit.org/changeset/201432>
Comment 4 WebKit Commit Bot 2016-05-26 14:56:52 PDT 
All reviewed patches have been landed.  Closing bug.