Bug 158123 - prepare-ChangeLog not picking up changes in a particular class
Summary: prepare-ChangeLog not picking up changes in a particular class
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-05-26 11:18 PDT by Chelsea Pugh
Modified: 2016-06-01 17:12 PDT (History)
6 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Chelsea Pugh 2016-05-26 11:18:10 PDT
Related Radar for more information: rdar://problem/26423121
Comment 1 Jason Marcell 2016-06-01 12:04:53 PDT
We have a method that looks something like this and prepareChangelog isn’t smart enough to know that there are preprocessor macros in play here so it thinks the curly braces are all mismatched, thus hindering its ability to understand where the method ends and the next method begins.

- (void)bar:(void (^)())block
{
#if __WHATEVER >= 12345
    [blip foo:^(Fuzz *bar) {
        if (buzz) {
            dispatch_async(dispatch_get_main_queue(), ^{
#else
    [blip foo:^(NSData *bing) {
        if (buzz) {
            dispatch_async(dispatch_get_main_queue(), ^{
                _blah = baz.firstObject;
#endif
            });
        }
    }];
}