WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
158123
prepare-ChangeLog not picking up changes in a particular class
https://bugs.webkit.org/show_bug.cgi?id=158123
Summary
prepare-ChangeLog not picking up changes in a particular class
Chelsea Pugh
Reported
2016-05-26 11:18:10 PDT
Related Radar for more information:
rdar://problem/26423121
Attachments
Add attachment
proposed patch, testcase, etc.
Jason Marcell
Comment 1
2016-06-01 12:04:53 PDT
We have a method that looks something like this and prepareChangelog isn’t smart enough to know that there are preprocessor macros in play here so it thinks the curly braces are all mismatched, thus hindering its ability to understand where the method ends and the next method begins. - (void)bar:(void (^)())block { #if __WHATEVER >= 12345 [blip foo:^(Fuzz *bar) { if (buzz) { dispatch_async(dispatch_get_main_queue(), ^{ #else [blip foo:^(NSData *bing) { if (buzz) { dispatch_async(dispatch_get_main_queue(), ^{ _blah = baz.firstObject; #endif }); } }]; }
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug