Bug 158113 - NativeToJSValue is harcoding the $thisValue in some strings
Summary: NativeToJSValue is harcoding the $thisValue in some strings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alejandro G. Castro
URL:
Keywords:
Depends on:
Blocks: 156293
  Show dependency tree / graph
 
Reported: 2016-05-26 03:20 PDT by Alejandro G. Castro
Modified: 2016-05-26 09:09 PDT (History)
6 users (show)

See Also:

Attachments
Patch (4.11 KB, patch)
2016-05-26 03:28 PDT, Alejandro G. Castro 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews102 for mac-yosemite (869.77 KB, application/zip)
2016-05-26 04:09 PDT, Build Bot 		no flags Details
Patch (4.09 KB, patch)
2016-05-26 08:28 PDT, Alejandro G. Castro 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alejandro G. Castro 2016-05-26 03:20:38 PDT 
In some situations the string representing thisValue is hardcoded, this was unnoticed because in those situations the hardcoded value what the same used. Just noticed when trying to change it.
Comment 1 Alejandro G. Castro 2016-05-26 03:28:02 PDT 
Created attachment 279874 [details]
Patch
Comment 2 Build Bot 2016-05-26 04:09:15 PDT 
Comment on attachment 279874 [details]
Patch

Attachment 279874 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1385247

Number of test failures exceeded the failure limit.
Comment 3 Build Bot 2016-05-26 04:09:19 PDT 
Created attachment 279876 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 4 Alejandro G. Castro 2016-05-26 08:28:25 PDT 
Created attachment 279886 [details]
Patch
Comment 5 Alejandro G. Castro 2016-05-26 08:29:16 PDT 
Uploading again to check if the mac failure is a real issue.
Comment 6 Darin Adler 2016-05-26 08:45:00 PDT 
Seems impossible that it’s related to this change.
Comment 7 WebKit Commit Bot 2016-05-26 09:09:23 PDT 
Comment on attachment 279886 [details]
Patch

Clearing flags on attachment: 279886

Committed r201419: <http://trac.webkit.org/changeset/201419>
Comment 8 WebKit Commit Bot 2016-05-26 09:09:27 PDT 
All reviewed patches have been landed.  Closing bug.