Bug 158107 - [GTK][Stable]: Merge r201072 and r201216 (and some misc gardening of accessibility tests)
Summary: [GTK][Stable]: Merge r201072 and r201216 (and some misc gardening of accessib...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: Other
Hardware: Unspecified Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-25 19:41 PDT by Joanmarie Diggs (irc: joanie)
Modified: 2016-08-22 06:06 PDT (History)
2 users (show)

See Also:


Attachments
Proposed patch (135.70 KB, patch)
2016-05-25 19:41 PDT, Joanmarie Diggs (irc: joanie)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joanmarie Diggs (irc: joanie) 2016-05-25 19:41:32 PDT
Created attachment 279859 [details]
Proposed patch

1. ​https://trac.webkit.org/changeset/201072 AX: [ATK] Use WebCore Accessibility's AccessibilityText for AtkObject name and description 

This change brings us into better compliance with a couple of W3C specs and fixes several bugs in which the accessible name of objects was missing or broken. Because Orca doesn't always know when/if the accessible name is broken, having this fix is desirable.

As part of that change, quite a few related layout tests were modified in a sad-hack interim step so that we could verify the correctness of the changes. The sad test hacks were removed as part of the next item.

2. https://trac.webkit.org/changeset/201216 AX: Layout tests related to text alternative computation need to be done differently

In addition to undoing the aforementioned sad test hacks, some testing utilities were added (just in a JavaScript resources file) and a bunch of tests modified to use those utilities. While this would not normally be something to include in a stable release, I would like us to include it if there are no objections. The reason why is that I'm finding quite a few accessibility bugs that impact Orca users. Whenever possible, I would like to backport them to the stable branch. And if we are going to cherry-pick patches for stable, I would like to be able to use our Layout Tests to ensure that we're cherry-picking everything needed and not breaking the stable release.

3. Some unrelated gardening that was done in master and would be helpful to include for reason described above.

Given that 2 is a continuation of 1, and limited to test changes only, I'm attaching a single patch.
Comment 1 Carlos Garcia Campos 2016-08-22 06:06:45 PDT
Merged in r204707. Thanks!