Bug 158104 - DebuggerCallFrame crashes when updated with the globalExec because neither ShadowChicken's algorithm nor StackVisitor's algorithm reasons about the globalExec
Summary: DebuggerCallFrame crashes when updated with the globalExec because neither Sh...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-05-25 18:27 PDT by Saam Barati
Modified: 2016-05-27 16:41 PDT (History)
16 users (show)

See Also:

Attachments
WIP (2.79 KB, patch)
2016-05-26 17:58 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
patch (6.13 KB, patch)
2016-05-27 14:32 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2016-05-25 18:27:34 PDT 
Also, there is a bad assertion in ::create because the top frame is allowed to be a tail deleted frame.
Comment 1 Saam Barati 2016-05-26 13:14:32 PDT 
I think we should special case this inside DebuggerCallFrame.
Comment 2 Saam Barati 2016-05-26 13:14:57 PDT 
(In reply to comment #1)
> I think we should special case this inside DebuggerCallFrame.

To elaborate, I don't think it's correct to have ShadowChicken handle
this. It shouldn't have to reason about the globalExec()
Comment 3 Saam Barati 2016-05-26 17:14:22 PDT 
rdar://problem/26467869
Comment 4 Saam Barati 2016-05-26 17:58:23 PDT 
Created attachment 279931 [details]
WIP

this is a test case
Comment 5 Saam Barati 2016-05-27 14:32:45 PDT 
Created attachment 279995 [details]
patch
Comment 6 Filip Pizlo 2016-05-27 14:34:21 PDT 
Comment on attachment 279995 [details]
patch

lol
Comment 7 WebKit Commit Bot 2016-05-27 16:40:56 PDT 
Comment on attachment 279995 [details]
patch

Clearing flags on attachment: 279995

Committed r201473: <http://trac.webkit.org/changeset/201473>
Comment 8 WebKit Commit Bot 2016-05-27 16:41:01 PDT 
All reviewed patches have been landed.  Closing bug.