Bug 158096 - REGRESSION (r191531): Web Inspector: WebSQL databases are no longer shown when first opening Web Inspector
Summary: REGRESSION (r191531): Web Inspector: WebSQL databases are no longer shown whe...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-05-25 15:25 PDT by Joseph Pecoraro
Modified: 2016-05-25 16:17 PDT (History)
9 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (1.71 KB, patch)
2016-05-25 15:29 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2016-05-25 15:25:58 PDT
* SUMMARY
WebSQL databases are no longer shown when first opening Web Inspector.

* NOTES
- r191531 added a FAST_RETURN_IF_NO_FRONTENDS, which prevents InspectorDatabaseAgent from tracking databases before inspector is open.
Comment 1 Joseph Pecoraro 2016-05-25 15:26:30 PDT
<rdar://problem/26454671>
Comment 2 Joseph Pecoraro 2016-05-25 15:29:24 PDT
Created attachment 279828 [details]
[PATCH] Proposed Fix
Comment 3 BJ Burg 2016-05-25 15:51:44 PDT
Comment on attachment 279828 [details]
[PATCH] Proposed Fix

r=me

It is worrying that there is no test coverage in this part of the code, but not surprising either.
Comment 4 WebKit Commit Bot 2016-05-25 16:17:21 PDT
Comment on attachment 279828 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 279828

Committed r201409: <http://trac.webkit.org/changeset/201409>
Comment 5 WebKit Commit Bot 2016-05-25 16:17:27 PDT
All reviewed patches have been landed.  Closing bug.