Bug 158069 – Web Inspector: sometimes reloading a page with main resource selected will show an empty content view

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Blaze Burg]

STEPS TO REPRODUCE:

0. Go to http://bl.ocks.org/syntagmatic/raw/6c149c08fc9cde682635/iridium-33-debris.html
1. Open Resources tab.
2. Select the main resource (iridium-33-debris.hmtl)
3. Reload with Cmd-R

EXPECTED:

The main resource tree element is re-selected when available and shows its HTML in editor

ACTUAL:

A blank content view is shown about 50% of the time.

NOTES:

Whether it reprouces or not seems related to resource load ordering. Try clearing caches between loads if it doesn't repro.

[Joseph Pecoraro]

I've noticed this too. I think it has to do with a background tab, thinking it is visible, steals the SourceCodeTextEditor from the actual visible tab... I haven't verified this yet though.

[Joseph Pecoraro]

I have that suspicious because I think switching tabs and switching back fixes the issue.

[Blaze Burg]

Ping for import.

[Radar WebKit Bug Importer]

<rdar://problem/26516710>

[Timothy Hatcher]

*** Bug 158402 has been marked as a duplicate of this bug. ***

[Joseph Pecoraro]

Created attachment 282834 [details]
[PATCH] Proposed Fix

This isn't an ideal fix, but it addresses this situation and didn't introduce any regressions with my testing.

[Timothy Hatcher]

Comment on attachment 282834 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=282834&action=review

> Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js:213
> +        if (WebInspector.navigationSidebar.selectedSidebarPanel !== this) {

Do sidebar panels have a parent property? Could this be if (this.selected) or if (this.parent.selectedSidebarPanel === this)? That would avoid the layer violation.

[Timothy Hatcher]

Comment on attachment 282834 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=282834&action=review

>> Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js:213
>> +        if (WebInspector.navigationSidebar.selectedSidebarPanel !== this) {
> 
> Do sidebar panels have a parent property? Could this be if (this.selected) or if (this.parent.selectedSidebarPanel === this)? That would avoid the layer violation.

Now that I can look at the code, this should be written as:

if (this.selected)

Or

if (this.parentSidebar.selectedSidebarPanel === this)

[Joseph Pecoraro]

(In reply to comment #8)
> Comment on attachment 282834 [details]
> [PATCH] Proposed Fix
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=282834&action=review
> 
> >> Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js:213
> >> +        if (WebInspector.navigationSidebar.selectedSidebarPanel !== this) {
> > 
> > Do sidebar panels have a parent property? Could this be if (this.selected) or if (this.parent.selectedSidebarPanel === this)? That would avoid the layer violation.
> 
> Now that I can look at the code, this should be written as:
> 
> if (this.selected)

Much better!

[Joseph Pecoraro]

<https://trac.webkit.org/changeset/202876>