Bug 158066 - REGRESSION(r201066): [GTK] Several intl tests started to fail in GTK+ bot after r201066
Summary: REGRESSION(r201066): [GTK] Several intl tests started to fail in GTK+ bot aft...
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Keywords: Gtk, LayoutTestFailure
Depends on:
Blocks: 157755
  Show dependency treegraph
Reported: 2016-05-25 05:23 PDT by Carlos Garcia Campos
Modified: 2016-05-25 08:22 PDT (History)
3 users (show)

See Also:

Patch for landing (1.95 KB, patch)
2016-05-25 05:26 PDT, Carlos Garcia Campos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2016-05-25 05:23:46 PDT
This is because since r201066 JSC also uses the preferred language from the system locale instead of falling back to "en" and those tests expect the locale to be en_US. run-javascriptcore-tests does $ENV{LANG}="en_US.UTF-8"; but we are not actually honoring the environment variables at all when using jsc binary. We are using setlocale with a nullptr locale to get the current one, but the current one is always "C", because to set the locale according to the environment variables we need to call setlocale with an empty string as locale. That's done by gtk_init(), which is called by all our binaries (web process, network process, etc.), but not by jsc (because jsc doesn't depend on GTK+). The reason why it has always worked for EFL is because they call ecore_init() in jsc that calls setlocale.
Comment 1 Carlos Garcia Campos 2016-05-25 05:26:30 PDT
Created attachment 279759 [details]
Patch for landing
Comment 2 Csaba Osztrogonác 2016-05-25 05:48:01 PDT
r201066 made the following tests fail on JSCOnly ARM bots:

but fixed these tests:
Comment 3 Carlos Garcia Campos 2016-05-25 08:22:40 PDT
Committed r201383: <http://trac.webkit.org/changeset/201383>