RESOLVED FIXED 158057
Uncaught Exception: TypeError: undefined is not an object (evaluating 'records[endIndex].endTime')
https://bugs.webkit.org/show_bug.cgi?id=158057
Summary Uncaught Exception: TypeError: undefined is not an object (evaluating 'record...
Blaze Burg
Reported 2016-05-24 21:03:12 PDT
------- Auto-generated details: Inspected URL: http://bl.ocks.org/syntagmatic/6c149c08fc9cde682635 Loading completed: true Frontend User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_5) AppleWebKit/602.1.34+ (KHTML, like Gecko) Uncaught exceptions: - TypeError: undefined is not an object (evaluating 'records[endIndex].endTime') (at RenderingFrameTimelineView.js:174:33) ------- * STEPS TO REPRODUCE 1. Create a timeline recording 2. Switch to rendering frames view 3. Double-click the frames overview * EXPECTED It sets the selection interval to the visible interval (the overview view does this correctly) * ACTUAL Raises an exception
Attachments
[Patch] Proposed Fix (2.75 KB, patch)
2016-05-26 00:05 PDT, Matt Baker
no flags
Matt Baker
Comment 1 2016-05-26 00:05:21 PDT
Created attachment 279870 [details] [Patch] Proposed Fix
Timothy Hatcher
Comment 2 2016-05-26 09:07:14 PDT
Comment on attachment 279870 [details] [Patch] Proposed Fix This works, but it also seems like WebInspector.RenderingFrameTimelineView should handle internally to avoid the logic spilling out into this code.
Matt Baker
Comment 3 2016-05-26 12:31:14 PDT
(In reply to comment #2) > Comment on attachment 279870 [details] > [Patch] Proposed Fix > > This works, but it also seems like WebInspector.RenderingFrameTimelineView > should handle internally to avoid the logic spilling out into this code. I agree, TimelineRecordingContentView does a lot of type checking.
Radar WebKit Bug Importer
Comment 4 2016-05-26 12:31:35 PDT
WebKit Commit Bot
Comment 5 2016-05-26 16:03:59 PDT
Comment on attachment 279870 [details] [Patch] Proposed Fix Clearing flags on attachment: 279870 Committed r201438: <http://trac.webkit.org/changeset/201438>
WebKit Commit Bot
Comment 6 2016-05-26 16:04:03 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.