Bug 158057 - Uncaught Exception: TypeError: undefined is not an object (evaluating 'records[endIndex].endTime')
Summary: Uncaught Exception: TypeError: undefined is not an object (evaluating 'record...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Matt Baker
URL: http://bl.ocks.org/syntagmatic/6c149c...
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-05-24 21:03 PDT by BJ Burg
Modified: 2016-05-26 16:04 PDT (History)
8 users (show)

See Also:


Attachments
[Patch] Proposed Fix (2.75 KB, patch)
2016-05-26 00:05 PDT, Matt Baker
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2016-05-24 21:03:12 PDT
-------
Auto-generated details:

Inspected URL:        http://bl.ocks.org/syntagmatic/6c149c08fc9cde682635
Loading completed:    true
Frontend User Agent:  Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_5) AppleWebKit/602.1.34+ (KHTML, like Gecko)
Uncaught exceptions:
 - TypeError: undefined is not an object (evaluating 'records[endIndex].endTime') (at RenderingFrameTimelineView.js:174:33)
-------

* STEPS TO REPRODUCE
1. Create a timeline recording
2. Switch to rendering frames view
3. Double-click the frames overview

* EXPECTED

It sets the selection interval to the visible interval (the overview view does this correctly)

* ACTUAL

Raises an exception
Comment 1 Matt Baker 2016-05-26 00:05:21 PDT
Created attachment 279870 [details]
[Patch] Proposed Fix
Comment 2 Timothy Hatcher 2016-05-26 09:07:14 PDT
Comment on attachment 279870 [details]
[Patch] Proposed Fix

This works, but it also seems like WebInspector.RenderingFrameTimelineView should handle internally to avoid the logic spilling out into this code.
Comment 3 Matt Baker 2016-05-26 12:31:14 PDT
(In reply to comment #2)
> Comment on attachment 279870 [details]
> [Patch] Proposed Fix
> 
> This works, but it also seems like WebInspector.RenderingFrameTimelineView
> should handle internally to avoid the logic spilling out into this code.

I agree, TimelineRecordingContentView does a lot of type checking.
Comment 4 Radar WebKit Bug Importer 2016-05-26 12:31:35 PDT
<rdar://problem/26499840>
Comment 5 WebKit Commit Bot 2016-05-26 16:03:59 PDT
Comment on attachment 279870 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 279870

Committed r201438: <http://trac.webkit.org/changeset/201438>
Comment 6 WebKit Commit Bot 2016-05-26 16:04:03 PDT
All reviewed patches have been landed.  Closing bug.