RESOLVED FIXED 158053
Simplify a couple of lambda captures in the network cache code 
https://bugs.webkit.org/show_bug.cgi?id=158053
Summary Simplify a couple of lambda captures in the network cache code
Chris Dumez
Reported 2016-05-24 20:48:20 PDT
Simplify a couple of lambda captures in the network cache code.
Attachments
Patch (4.35 KB, patch)
2016-05-24 20:51 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-05-24 20:51:13 PDT
Created attachment 279738 [details] Patch
Brady Eidson
Comment 2 2016-05-24 21:53:49 PDT
Comment on attachment 279738 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=279738&action=review > Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp:-902 > - // Avoid non-thread safe std::function copies. > - auto* completionHandlerPtr = completionHandler ? new std::function<void ()>(WTFMove(completionHandler)) : nullptr; I see this comment, and it makes me wonder - How much thread hopping does the NetworkCacheStorage code do? We have a mechanism for this called "createCrossThreadTask" that perhaps you should look in to going forward.
WebKit Commit Bot
Comment 3 2016-05-24 22:16:52 PDT
Comment on attachment 279738 [details] Patch Clearing flags on attachment: 279738 Committed r201371: <http://trac.webkit.org/changeset/201371>
WebKit Commit Bot
Comment 4 2016-05-24 22:16:57 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.