Bug 158049 – _WKThumbnailView should expose its snapshot size

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Conrad Shultz]

_WKThumbnailView should expose its snapshot size and make it observable.

[Conrad Shultz]

<rdar://problem/26458877>

[Conrad Shultz]

Created attachment 279728 [details]
Patch

[Conrad Shultz]

Committed http://svn.webkit.org/repository/webkit/trunk@201366

[Sam Weinig]

Can you please add an API test for this?

[Darin Adler]

Comment on attachment 279728 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=279728&action=review

> Source/WebKit2/UIProcess/API/Cocoa/_WKThumbnailView.mm:144
> +    [self willChangeValueForKey:@"snapshotSize"];
> +
> +    _snapshotSize = CGSizeMake(CGImageGetWidth(image), CGImageGetHeight(image));

Should this optimize the case where the value of _snapshotSize is not changing to not call willChangeValueForKey/didChangeValueForKey in that case? Maybe it’s common to update the snapshot without the image size changing?

[Conrad Shultz]

(In reply to comment #4)
> Can you please add an API test for this?

I'll look into it!

[Conrad Shultz]

(In reply to comment #5)
> Comment on attachment 279728 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=279728&action=review
> 
> > Source/WebKit2/UIProcess/API/Cocoa/_WKThumbnailView.mm:144
> > +    [self willChangeValueForKey:@"snapshotSize"];
> > +
> > +    _snapshotSize = CGSizeMake(CGImageGetWidth(image), CGImageGetHeight(image));
> 
> Should this optimize the case where the value of _snapshotSize is not
> changing to not call willChangeValueForKey/didChangeValueForKey in that
> case? Maybe it’s common to update the snapshot without the image size
> changing?

Hopefully updates overall aren't particularly common, and I generally expect any observers to check the value to see whether the change was of interest, but there's probably no harm in further optimizing here.