WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
158049
_WKThumbnailView should expose its snapshot size
https://bugs.webkit.org/show_bug.cgi?id=158049
Summary
_WKThumbnailView should expose its snapshot size
Conrad Shultz
Reported
2016-05-24 17:34:15 PDT
_WKThumbnailView should expose its snapshot size and make it observable.
Attachments
Patch
(2.59 KB, patch)
2016-05-24 17:36 PDT
,
Conrad Shultz
thorton
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Conrad Shultz
Comment 1
2016-05-24 17:34:47 PDT
<
rdar://problem/26458877
>
Conrad Shultz
Comment 2
2016-05-24 17:36:45 PDT
Created
attachment 279728
[details]
Patch
Conrad Shultz
Comment 3
2016-05-24 17:45:43 PDT
Committed
http://svn.webkit.org/repository/webkit/trunk@201366
Sam Weinig
Comment 4
2016-05-24 22:02:33 PDT
Can you please add an API test for this?
Darin Adler
Comment 5
2016-05-25 03:35:34 PDT
Comment on
attachment 279728
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=279728&action=review
> Source/WebKit2/UIProcess/API/Cocoa/_WKThumbnailView.mm:144 > + [self willChangeValueForKey:@"snapshotSize"]; > + > + _snapshotSize = CGSizeMake(CGImageGetWidth(image), CGImageGetHeight(image));
Should this optimize the case where the value of _snapshotSize is not changing to not call willChangeValueForKey/didChangeValueForKey in that case? Maybe it’s common to update the snapshot without the image size changing?
Conrad Shultz
Comment 6
2016-05-25 10:27:25 PDT
(In reply to
comment #4
)
> Can you please add an API test for this?
I'll look into it!
Conrad Shultz
Comment 7
2016-05-25 10:28:49 PDT
(In reply to
comment #5
)
> Comment on
attachment 279728
[details]
> Patch > > View in context: >
https://bugs.webkit.org/attachment.cgi?id=279728&action=review
> > > Source/WebKit2/UIProcess/API/Cocoa/_WKThumbnailView.mm:144 > > + [self willChangeValueForKey:@"snapshotSize"]; > > + > > + _snapshotSize = CGSizeMake(CGImageGetWidth(image), CGImageGetHeight(image)); > > Should this optimize the case where the value of _snapshotSize is not > changing to not call willChangeValueForKey/didChangeValueForKey in that > case? Maybe it’s common to update the snapshot without the image size > changing?
Hopefully updates overall aren't particularly common, and I generally expect any observers to check the value to see whether the change was of interest, but there's probably no harm in further optimizing here.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug