RESOLVED FIXED 158047
Reorganize dashboard code: move code from _timeIntervalString to base class 
https://bugs.webkit.org/show_bug.cgi?id=158047
Summary Reorganize dashboard code: move code from _timeIntervalString to base class
Aakash Jain
Reported 2016-05-24 16:36:40 PDT
See <rdar://problem/26457274>.
Attachments
Proposed patch (3.33 KB, patch)
2016-05-24 16:48 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Updated patch (3.38 KB, patch)
2016-05-24 17:21 PDT, Aakash Jain 		ap: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews103 for mac-yosemite (1.58 MB, application/zip)
2016-05-24 17:47 PDT, Build Bot 		no flags
Details
Updated patch (3.39 KB, patch)
2016-05-24 17:59 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2016-05-24 16:48:03 PDT
Created attachment 279722 [details] Proposed patch
Dean Johnson
Comment 2 2016-05-24 17:00:17 PDT
Comment on attachment 279722 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=279722&action=review Looks good other than comments :) > Tools/ChangeLog:3 > + Reorganize dashboard code This sounds like a big patch by the name, can you be more specific here? Maybe: Move code from _timeIntervalString to base class?
Aakash Jain
Comment 3 2016-05-24 17:21:49 PDT
Created attachment 279725 [details] Updated patch
Build Bot
Comment 4 2016-05-24 17:47:07 PDT
Comment on attachment 279725 [details] Updated patch Attachment 279725 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/1377398 Number of test failures exceeded the failure limit.
Build Bot
Comment 5 2016-05-24 17:47:10 PDT
Created attachment 279730 [details] Archive of layout-test-results from ews103 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-yosemite Platform: Mac OS X 10.10.5
Alexey Proskuryakov
Comment 6 2016-05-24 17:50:11 PDT
Comment on attachment 279725 [details] Updated patch View in context: https://bugs.webkit.org/attachment.cgi?id=279725&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:232 > + _getReadableTimeString: function(seconds) Coding style: we don't use "get" naming for functions that just return a value.
Aakash Jain
Comment 7 2016-05-24 17:59:13 PDT
Created attachment 279732 [details] Updated patch
WebKit Commit Bot
Comment 8 2016-05-24 18:20:37 PDT
Comment on attachment 279732 [details] Updated patch Clearing flags on attachment: 279732 Committed r201370: <http://trac.webkit.org/changeset/201370>
WebKit Commit Bot
Comment 9 2016-05-24 18:20:42 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.