Bug 158047 - Reorganize dashboard code: move code from _timeIntervalString to base class
Summary: Reorganize dashboard code: move code from _timeIntervalString to base class
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-24 16:36 PDT by Aakash Jain
Modified: 2016-05-24 18:20 PDT (History)
6 users (show)

See Also:

Attachments
Proposed patch (3.33 KB, patch)
2016-05-24 16:48 PDT, Aakash Jain 		no flags Details | Formatted Diff | Diff
Updated patch (3.38 KB, patch)
2016-05-24 17:21 PDT, Aakash Jain 		ap: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews103 for mac-yosemite (1.58 MB, application/zip)
2016-05-24 17:47 PDT, Build Bot 		no flags Details
Updated patch (3.39 KB, patch)
2016-05-24 17:59 PDT, Aakash Jain 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2016-05-24 16:36:40 PDT 
See <rdar://problem/26457274>.
Comment 1 Aakash Jain 2016-05-24 16:48:03 PDT 
Created attachment 279722 [details]
Proposed patch
Comment 2 Dean Johnson 2016-05-24 17:00:17 PDT 
Comment on attachment 279722 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=279722&action=review

Looks good other than comments :)

> Tools/ChangeLog:3
> +        Reorganize dashboard code

This sounds like a big patch by the name, can you be more specific here? Maybe: Move code from _timeIntervalString to base class?
Comment 3 Aakash Jain 2016-05-24 17:21:49 PDT 
Created attachment 279725 [details]
Updated patch
Comment 4 Build Bot 2016-05-24 17:47:07 PDT 
Comment on attachment 279725 [details]
Updated patch

Attachment 279725 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1377398

Number of test failures exceeded the failure limit.
Comment 5 Build Bot 2016-05-24 17:47:10 PDT 
Created attachment 279730 [details]
Archive of layout-test-results from ews103 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 6 Alexey Proskuryakov 2016-05-24 17:50:11 PDT 
Comment on attachment 279725 [details]
Updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=279725&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:232
> +    _getReadableTimeString: function(seconds)

Coding style: we don't use "get" naming for functions that just return a value.
Comment 7 Aakash Jain 2016-05-24 17:59:13 PDT 
Created attachment 279732 [details]
Updated patch
Comment 8 WebKit Commit Bot 2016-05-24 18:20:37 PDT 
Comment on attachment 279732 [details]
Updated patch

Clearing flags on attachment: 279732

Committed r201370: <http://trac.webkit.org/changeset/201370>
Comment 9 WebKit Commit Bot 2016-05-24 18:20:42 PDT 
All reviewed patches have been landed.  Closing bug.