RESOLVED FIXED 158045
REGRESSION: JSBench spends a lot of time transitioning to/from dictionary
https://bugs.webkit.org/show_bug.cgi?id=158045
Summary REGRESSION: JSBench spends a lot of time transitioning to/from dictionary
Geoffrey Garen
Reported 2016-05-24 16:28:28 PDT
REGRESSION: JSBench spends a lot of time transitioning to/from dictionary
Attachments
Patch (7.29 KB, patch)
2016-05-24 16:36 PDT, Geoffrey Garen
saam: review+
buildbot: commit-queue-
Archive of layout-test-results from ews105 for mac-yosemite-wk2 (930.05 KB, application/zip)
2016-05-24 17:29 PDT, Build Bot
no flags
Archive of layout-test-results from ews101 for mac-yosemite (856.12 KB, application/zip)
2016-05-24 17:32 PDT, Build Bot
no flags
Archive of layout-test-results from ews124 for ios-simulator-wk2 (646.02 KB, application/zip)
2016-05-24 17:41 PDT, Build Bot
no flags
Archive of layout-test-results from ews116 for mac-yosemite (1.19 MB, application/zip)
2016-05-24 17:49 PDT, Build Bot
no flags
Geoffrey Garen
Comment 1 2016-05-24 16:36:48 PDT
Saam Barati
Comment 2 2016-05-24 16:52:45 PDT
Comment on attachment 279719 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=279719&action=review r=me > Source/JavaScriptCore/runtime/Operations.h:212 > + if (structure->hasBeenFlattenedBefore()) > + return InvalidPrototypeChain; Is it worth having an assertion in flattenDictionaryStructure to make sure we don't end up in a cycle of flattening?
Geoffrey Garen
Comment 3 2016-05-24 17:04:43 PDT
> Is it worth having an assertion in flattenDictionaryStructure to make sure > we don't end up in a cycle of flattening? I'm not sure. Right now, flattening is a policy decision, and some callers choose to flatten even if in a cycle. We could add the assertion, but only after changing the policy. It's not clear to me if a policy change is warranted or not.
Build Bot
Comment 4 2016-05-24 17:28:57 PDT
Comment on attachment 279719 [details] Patch Attachment 279719 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/1377260 New failing tests: js/cached-window-properties.html
Build Bot
Comment 5 2016-05-24 17:29:00 PDT
Created attachment 279726 [details] Archive of layout-test-results from ews105 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Build Bot
Comment 6 2016-05-24 17:32:54 PDT
Comment on attachment 279719 [details] Patch Attachment 279719 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/1377274 New failing tests: js/cached-window-properties.html
Build Bot
Comment 7 2016-05-24 17:32:59 PDT
Created attachment 279727 [details] Archive of layout-test-results from ews101 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-yosemite Platform: Mac OS X 10.10.5
Build Bot
Comment 8 2016-05-24 17:40:55 PDT
Comment on attachment 279719 [details] Patch Attachment 279719 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/1377277 New failing tests: js/cached-window-properties.html
Build Bot
Comment 9 2016-05-24 17:41:00 PDT
Created attachment 279729 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.4
Build Bot
Comment 10 2016-05-24 17:49:23 PDT
Comment on attachment 279719 [details] Patch Attachment 279719 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/1377291 New failing tests: js/cached-window-properties.html
Build Bot
Comment 11 2016-05-24 17:49:27 PDT
Created attachment 279731 [details] Archive of layout-test-results from ews116 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-yosemite Platform: Mac OS X 10.10.5
Geoffrey Garen
Comment 12 2016-05-26 15:28:54 PDT
Saam Barati
Comment 13 2016-05-26 17:19:59 PDT
(In reply to comment #12) > Committed r201436: <http://trac.webkit.org/changeset/201436> Looks like this might also be a 9% code-load speedup https://arewefastyet.com/#machine=29&view=breakdown&suite=octane
Ryosuke Niwa
Comment 14 2016-05-26 19:48:54 PDT
This patch appears to have caused 30% regression on Dromaeo DOM core.
WebKit Commit Bot
Comment 15 2016-05-26 19:52:27 PDT
Re-opened since this is blocked by bug 158143
Geoffrey Garen
Comment 16 2016-06-01 15:21:01 PDT
Ryosuke Niwa
Comment 17 2016-06-01 19:56:26 PDT
This was 3% overall JSBench progression.
Note You need to log in before you can comment on or make changes to this bug.