Bug 158041 - We Should be able to use the sampling profiler with DRT/WTR.
Summary: We Should be able to use the sampling profiler with DRT/WTR.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-24 15:03 PDT by Keith Miller
Modified: 2016-05-24 16:02 PDT (History)
4 users (show)

See Also:

Attachments
Patch (9.02 KB, patch)
2016-05-24 15:18 PDT, Keith Miller 		no flags Details | Formatted Diff | Diff
Patch for landing (9.05 KB, patch)
2016-05-24 15:33 PDT, Keith Miller 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2016-05-24 15:03:20 PDT 
We Should be able to use the sampling profiler with DRT/WTR.
Comment 1 Keith Miller 2016-05-24 15:18:12 PDT 
Created attachment 279711 [details]
Patch
Comment 2 Saam Barati 2016-05-24 15:24:48 PDT 
Comment on attachment 279711 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=279711&action=review

r=me with comments

> Source/JavaScriptCore/runtime/SamplingProfiler.cpp:767
> +    static HashSet<SamplingProfiler*>* profilesToReport;

You can just do HashSet<RefPtr<SamplingProfiler>> instead of manually ref()ing.

> Source/JavaScriptCore/runtime/SamplingProfiler.h:180
> +    bool m_needsReportAtExit;

This should default to sing false.
Comment 3 Saam Barati 2016-05-24 15:27:49 PDT 
Comment on attachment 279711 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=279711&action=review

>> Source/JavaScriptCore/runtime/SamplingProfiler.h:180
>> +    bool m_needsReportAtExit;
> 
> This should default to sing false.

being*
Comment 4 Keith Miller 2016-05-24 15:33:02 PDT 
Created attachment 279713 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2016-05-24 16:02:02 PDT 
Comment on attachment 279713 [details]
Patch for landing

Clearing flags on attachment: 279713

Committed r201361: <http://trac.webkit.org/changeset/201361>
Comment 6 WebKit Commit Bot 2016-05-24 16:02:06 PDT 
All reviewed patches have been landed.  Closing bug.