Bug 158040 - REGRESSION(r189567): Elements with aspect ratios are not handled correctly inside flexbox
Summary: REGRESSION(r189567): Elements with aspect ratios are not handled correctly in...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-05-24 14:05 PDT by Dave Hyatt
Modified: 2016-06-02 20:00 PDT (History)
7 users (show)

See Also:

Attachments
Patch (109.83 KB, patch)
2016-05-24 14:07 PDT, Dave Hyatt 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2016-05-24 14:05:10 PDT 
Elements with aspect ratios are not having their intrinsic sizes for min/max adjusted correctly. This includes images, canvas and video.
Comment 1 Dave Hyatt 2016-05-24 14:07:44 PDT 
Created attachment 279702 [details]
Patch
Comment 2 WebKit Commit Bot 2016-05-24 14:09:59 PDT 
Attachment 279702 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/RenderFlexibleBox.cpp:878:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/rendering/RenderFlexibleBox.cpp:879:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/WebCore/rendering/RenderFlexibleBox.cpp:885:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/WebCore/rendering/RenderFlexibleBox.cpp:886:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/WebCore/rendering/RenderFlexibleBox.cpp:887:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/WebCore/rendering/RenderFlexibleBox.cpp:888:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/WebCore/rendering/RenderFlexibleBox.cpp:889:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/WebCore/rendering/RenderFlexibleBox.cpp:892:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/WebCore/rendering/RenderFlexibleBox.cpp:948:  An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Total errors found: 9 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Commit Bot 2016-05-31 11:41:00 PDT 
Comment on attachment 279702 [details]
Patch

Clearing flags on attachment: 279702

Committed r201516: <http://trac.webkit.org/changeset/201516>
Comment 4 WebKit Commit Bot 2016-05-31 11:41:06 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Jon Lee 2016-05-31 11:42:07 PDT 
rdar://problem/26235068