Bug 158031 - Map should not be in JSGlobalObject's static hashtable because it's initialized eagerly via FOR_EACH_SIMPLE_BUILTIN_TYPE_WITH_CONSTRUCTOR
Summary: Map should not be in JSGlobalObject's static hashtable because it's initializ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-24 11:26 PDT by Filip Pizlo
Modified: 2016-05-24 12:03 PDT (History)
10 users (show)

See Also:

Attachments
the patch (3.48 KB, patch)
2016-05-24 11:28 PDT, Filip Pizlo 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2016-05-24 11:26:10 PDT 
Patch forthcoming.
Comment 1 Filip Pizlo 2016-05-24 11:28:19 PDT 
Created attachment 279677 [details]
the patch
Comment 2 Geoffrey Garen 2016-05-24 11:43:24 PDT 
Comment on attachment 279677 [details]
the patch

r=me
Comment 3 Mark Lam 2016-05-24 11:46:05 PDT 
Comment on attachment 279677 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=279677&action=review

> Source/JavaScriptCore/tests/stress/override-map-constructor.js:1
> +function Map() {

Please add a comment above this that says "Should not crash".  This gives us a clue to what was expected of this test since it is very bare.
Comment 4 Filip Pizlo 2016-05-24 12:00:57 PDT 
Landed in http://trac.webkit.org/changeset/201340
Comment 5 Filip Pizlo 2016-05-24 12:01:24 PDT 
(In reply to comment #3)
> Comment on attachment 279677 [details]
> the patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=279677&action=review
> 
> > Source/JavaScriptCore/tests/stress/override-map-constructor.js:1
> > +function Map() {
> 
> Please add a comment above this that says "Should not crash".  This gives us
> a clue to what was expected of this test since it is very bare.

Ooops, I landed before seeing this comment.  I will fix in a follow-up.
Comment 6 Filip Pizlo 2016-05-24 12:03:46 PDT 
(In reply to comment #5)
> (In reply to comment #3)
> > Comment on attachment 279677 [details]
> > the patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=279677&action=review
> > 
> > > Source/JavaScriptCore/tests/stress/override-map-constructor.js:1
> > > +function Map() {
> > 
> > Please add a comment above this that says "Should not crash".  This gives us
> > a clue to what was expected of this test since it is very bare.
> 
> Ooops, I landed before seeing this comment.  I will fix in a follow-up.

Addressed in http://trac.webkit.org/changeset/201342.