Bug 158015 - [Font Loading] ASSERT if calling FontFace.loaded twice with a garbage collection between them
Summary: [Font Loading] ASSERT if calling FontFace.loaded twice with a garbage collect...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-23 23:08 PDT by Myles C. Maxfield
Modified: 2016-05-25 12:06 PDT (History)
6 users (show)

See Also:


Attachments
Patch (6.06 KB, patch)
2016-05-23 23:15 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews102 for mac-yosemite (1.05 MB, application/zip)
2016-05-23 23:45 PDT, Build Bot
no flags Details
Patch (6.33 KB, patch)
2016-05-24 15:54 PDT, Myles C. Maxfield
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2016-05-23 23:08:11 PDT
[Font Loading] ASSERT if calling FontFace.loaded twice with a garbage collection between them
Comment 1 Myles C. Maxfield 2016-05-23 23:15:14 PDT
Created attachment 279628 [details]
Patch
Comment 2 Build Bot 2016-05-23 23:45:28 PDT
Comment on attachment 279628 [details]
Patch

Attachment 279628 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1373103

New failing tests:
fast/text/font-loading-csp-block-all.html
fast/text/css-font-loading-arraybuffer.html
Comment 3 Build Bot 2016-05-23 23:45:31 PDT
Created attachment 279631 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 4 Myles C. Maxfield 2016-05-24 15:54:55 PDT
Created attachment 279716 [details]
Patch
Comment 5 Darin Adler 2016-05-25 03:39:33 PDT
Comment on attachment 279716 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=279716&action=review

> Source/WebCore/bindings/js/JSFontFaceCustom.cpp:38
>  JSC::JSValue JSFontFace::loaded(JSC::ExecState& state) const

How can we get rid of the need for a custom binding for this function?
Comment 6 Myles C. Maxfield 2016-05-25 11:05:52 PDT
Comment on attachment 279716 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=279716&action=review

>> Source/WebCore/bindings/js/JSFontFaceCustom.cpp:38
>>  JSC::JSValue JSFontFace::loaded(JSC::ExecState& state) const
> 
> How can we get rid of the need for a custom binding for this function?

We would have to have some way of associating the Promise inside the FontFace class with the promise inside the JSFontFace class.
Comment 7 Myles C. Maxfield 2016-05-25 12:06:55 PDT
Committed r201394: <http://trac.webkit.org/changeset/201394>