WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED WONTFIX
158014
[JSC][DOM] Always pass receiver and slotBase to custom (value/accessor) getter
https://bugs.webkit.org/show_bug.cgi?id=158014
Summary
[JSC][DOM] Always pass receiver and slotBase to custom (value/accessor) getter
Yusuke Suzuki
Reported
2016-05-23 22:41:52 PDT
Currently, custom value getter receives slotBase as the second argument, but custom accessor getter takes the receiver as the second argument. We should unify this behavior.
Attachments
Add attachment
proposed patch, testcase, etc.
Sam Weinig
Comment 1
2017-04-25 18:29:19 PDT
I've lost track of the terminology. What are "custom value getters" and what are "custom accessor getters"? Do we use both for the DOM?
Yusuke Suzuki
Comment 2
2017-04-25 23:26:45 PDT
(In reply to Sam Weinig from
comment #1
)
> I've lost track of the terminology. What are "custom value getters" and what > are "custom accessor getters"? Do we use both for the DOM?
The custom value getters are shown as usual value from the user. But internally it invokes a custom function. The custom accessor getter is shown as a JS accessor which invokes a custom function. After considering this, I think now it is not necessary. It is better to leave the current one since 1. All the current custom accessor just requires this value. Previously ES6 Proxy was an exception. But now the design is changed and it is not necessary. 2. All the current custom value accessor requires slot base.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug