Bug 158014 - [JSC][DOM] Always pass receiver and slotBase to custom (value/accessor) getter
Summary: [JSC][DOM] Always pass receiver and slotBase to custom (value/accessor) getter
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-23 22:41 PDT by Yusuke Suzuki
Modified: 2017-04-25 23:26 PDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2016-05-23 22:41:52 PDT
Currently, custom value getter receives slotBase as the second argument, but custom accessor getter takes the receiver as the second argument.
We should unify this behavior.
Comment 1 Sam Weinig 2017-04-25 18:29:19 PDT
I've lost track of the terminology. What are "custom value getters" and what are "custom accessor getters"?  Do we use both for the DOM?
Comment 2 Yusuke Suzuki 2017-04-25 23:26:45 PDT
(In reply to Sam Weinig from comment #1)
> I've lost track of the terminology. What are "custom value getters" and what
> are "custom accessor getters"?  Do we use both for the DOM?

The custom value getters are shown as usual value from the user. But internally it invokes a custom function.
The custom accessor getter is shown as a JS accessor which invokes a custom function.

After considering this, I think now it is not necessary.
It is better to leave the current one since

1. All the current custom accessor just requires this value. Previously ES6 Proxy was an exception. But now the design is changed and it is not necessary.
2. All the current custom value accessor requires slot base.