The 2 first parameters to addEventListener() / removeEventListener() should be mandatory: https://dom.spec.whatwg.org/#interface-eventtarget Firefox 46 and Chrome 50 both match the specification and throw an exception when those parameters are omitted. However, those parameters are currently optional in WebKit and the calls are merely no-ops if the parameters are omitted.
Created attachment 279613 [details] Patch
Created attachment 279614 [details] Patch
Comment on attachment 279614 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=279614&action=review There is some risk of failure if an exception causes a problem, in content that was only ever tested with WebKit, that accidentally calls the addEventListener or removeEventListener with too few arguments. Like the video-remote-control-playpause.html test, for example. Is this worth the risk at this point? > Source/WebCore/ChangeLog:20 > + (GetFunctionLength): Deleted. This is untrue. The function was not deleted. This is a bug in the prepare-ChangeLog script "Deleted" feature. > Source/WebCore/ChangeLog:23 > + (WebCore::EventTarget::addEventListenerForBindings): Deleted. > + (WebCore::EventTarget::removeEventListenerForBindings): Deleted. Same thing here too.
(In reply to comment #3) > Comment on attachment 279614 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=279614&action=review > > There is some risk of failure if an exception causes a problem, in content > that was only ever tested with WebKit, that accidentally calls the > addEventListener or removeEventListener with too few arguments. Like the > video-remote-control-playpause.html test, for example. Is this worth the > risk at this point? I will wait to land it.
Created attachment 279619 [details] Patch
Created attachment 283919 [details] Patch
<rdar://problem/27408657>
Comment on attachment 283919 [details] Patch Clearing flags on attachment: 283919 Committed r203377: <http://trac.webkit.org/changeset/203377>
All reviewed patches have been landed. Closing bug.