Bug 157997 – [cmake] Deduplicate make-js-file-arrays usage and make it work on Windows.

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Konstantin Tokarev]

On Windows setting PYTHONPATH variable requires separate command.

[Konstantin Tokarev]

Created attachment 279584 [details]
Patch

[Alex Christensen]

Comment on attachment 279584 [details]
Patch

WebCore_USER_AGENT_SCRIPTS and WebCore_SDP_PROCESSOR_SCRIPTS aren't used on Windows.  What does this enable?

[Alex Christensen]

Comment on attachment 279584 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=279584&action=review

> Source/cmake/WebKitMacros.cmake:354
> +macro(MAKE_JS_FILE_ARRAYS _output_cpp _output_h _scripts _scripts_dependencies)

This macro is only used in WebCore/CMakeLists.txt, so there's no reason to share it with other CMakeLists.txt here.

[Konstantin Tokarev]

(In reply to comment #2)
> Comment on attachment 279584 [details]
> Patch
> 
> WebCore_USER_AGENT_SCRIPTS and WebCore_SDP_PROCESSOR_SCRIPTS aren't used on
> Windows.  What does this enable?

I'm using them in downstream port, and I think this is need for sake of completeness. Similar stuff like WebCore_USER_AGENT_STYLE_SHEETS works anywhere because perl supports -I arguments and python doesn't.

It will also be useful if someone decides to restore Windows support in WebKitGTK, or if you later decide to embed user scripts in Windows port instead of loading them from external file.

[Alex Christensen]

Comment on attachment 279584 [details]
Patch

All right.  I guess this doesn't hurt anything.

[WebKit Commit Bot]

Comment on attachment 279584 [details]
Patch

Clearing flags on attachment: 279584

Committed r201413: <http://trac.webkit.org/changeset/201413>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.