Bug 157992 - Need SPI for clients to require a user action to get an editing controls manager
Summary: Need SPI for clients to require a user action to get an editing controls manager
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-23 12:16 PDT by Beth Dakin
Modified: 2016-05-23 15:06 PDT (History)
4 users (show)

See Also:

Attachments
Patch (16.02 KB, patch)
2016-05-23 12:33 PDT, Beth Dakin 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Beth Dakin 2016-05-23 12:16:05 PDT 
Need SPI for clients to require a user action to get an editing controls manager

rdar://problem/26379927
Comment 1 Beth Dakin 2016-05-23 12:33:59 PDT 
Created attachment 279575 [details]
Patch
Comment 2 Tim Horton 2016-05-23 14:44:27 PDT 
Comment on attachment 279575 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=279575&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:683
> +- (BOOL)_requiresUserActionForEditingControlsManager

I would drop at *least* the "manager" from this name. Maybe see if Anders can come up with a better name?
Comment 3 Beth Dakin 2016-05-23 15:06:44 PDT 
http://trac.webkit.org/changeset/201298

Thanks Tim!