Bug 157989 - Remove padding and margin around the <math> element
Summary: Remove padding and margin around the <math> element
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: MathML (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Frédéric Wang (:fredw)
URL:
Keywords:
Depends on: 155433
Blocks: 159715
  Show dependency treegraph
 
Reported: 2016-05-23 08:28 PDT by Frédéric Wang (:fredw)
Modified: 2016-07-13 12:15 PDT (History)
5 users (show)

See Also:


Attachments
Patch (810 bytes, patch)
2016-05-23 08:28 PDT, Frédéric Wang (:fredw)
no flags Details | Formatted Diff | Diff
Patch (387.97 KB, patch)
2016-07-13 08:22 PDT, Frédéric Wang (:fredw)
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews101 for mac-yosemite (1.09 MB, application/zip)
2016-07-13 09:10 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews106 for mac-yosemite-wk2 (1.10 MB, application/zip)
2016-07-13 09:13 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews112 for mac-yosemite (1.75 MB, application/zip)
2016-07-13 09:27 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews122 for ios-simulator-wk2 (1.18 MB, application/zip)
2016-07-13 09:32 PDT, Build Bot
no flags Details
Patch (448.83 KB, patch)
2016-07-13 09:51 PDT, Frédéric Wang (:fredw)
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews102 for mac-yosemite (788.14 KB, application/zip)
2016-07-13 10:38 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews112 for mac-yosemite (1.49 MB, application/zip)
2016-07-13 10:56 PDT, Build Bot
no flags Details
Patch (447.76 KB, patch)
2016-07-13 11:00 PDT, Frédéric Wang (:fredw)
no flags Details | Formatted Diff | Diff
Patch (449.63 KB, patch)
2016-07-13 11:20 PDT, Frédéric Wang (:fredw)
bfulgham: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Frédéric Wang (:fredw) 2016-05-23 08:28:40 PDT
Created attachment 279565 [details]
Patch

The MathML user agent stylesheet has some 1px padding on the right/left of the <math> root. This was added a long time ago in

http://trac.webkit.org/changeset/61861/trunk/WebCore/css/mathml.css

but the intention is unclear, probably to tweak the spacing. I don't think that's necessary and it some tests have to revert this change to avoid 1px shifts, so let's remove it and keep the UA stylesheet minimal.
Comment 1 Manuel Rego Casasnovas 2016-07-12 06:35:55 PDT
Comment on attachment 279565 [details]
Patch

Yes sure, let's get rid of it. You'll need a bunch of rebaselines though, also the ChangeLog entry.
Comment 2 Frédéric Wang (:fredw) 2016-07-13 08:22:52 PDT
Created attachment 283528 [details]
Patch
Comment 3 Frédéric Wang (:fredw) 2016-07-13 08:24:36 PDT
The patch does the small CSS change for the <math> tag, remove all the hacks in the reftests and also rebaseline GTK tests. We will have to do the rebaseline for all the ports, though.
Comment 4 Build Bot 2016-07-13 09:10:19 PDT
Comment on attachment 283528 [details]
Patch

Attachment 283528 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1674785

New failing tests:
mathml/opentype/opentype-stretchy-horizontal.html
mathml/presentation/mo-stretch.html
mathml/radical-fallback.html
mathml/opentype/opentype-stretchy.html
mathml/presentation/mspace-children.html
mathml/mathml-in-dashboard.html
mathml/presentation/menclose-notation-values.html
mathml/presentation/roots.xhtml
mathml/presentation/menclose-notation-default-longdiv.html
Comment 5 Build Bot 2016-07-13 09:10:22 PDT
Created attachment 283534 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 6 Build Bot 2016-07-13 09:13:18 PDT
Comment on attachment 283528 [details]
Patch

Attachment 283528 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1674792

New failing tests:
mathml/opentype/opentype-stretchy-horizontal.html
mathml/presentation/mo-stretch.html
mathml/radical-fallback.html
mathml/opentype/opentype-stretchy.html
mathml/presentation/mspace-children.html
mathml/presentation/menclose-notation-values.html
mathml/presentation/roots.xhtml
mathml/presentation/menclose-notation-default-longdiv.html
Comment 7 Build Bot 2016-07-13 09:13:20 PDT
Created attachment 283535 [details]
Archive of layout-test-results from ews106 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 8 Build Bot 2016-07-13 09:27:35 PDT
Comment on attachment 283528 [details]
Patch

Attachment 283528 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1674837

New failing tests:
mathml/opentype/opentype-stretchy-horizontal.html
mathml/presentation/mo-stretch.html
mathml/radical-fallback.html
mathml/opentype/opentype-stretchy.html
mathml/presentation/mspace-children.html
mathml/mathml-in-dashboard.html
mathml/presentation/menclose-notation-values.html
mathml/presentation/roots.xhtml
mathml/presentation/menclose-notation-default-longdiv.html
Comment 9 Build Bot 2016-07-13 09:27:38 PDT
Created attachment 283536 [details]
Archive of layout-test-results from ews112 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 10 Build Bot 2016-07-13 09:32:11 PDT
Comment on attachment 283528 [details]
Patch

Attachment 283528 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1674818

New failing tests:
mathml/opentype/opentype-stretchy-horizontal.html
mathml/presentation/mo-stretch.html
mathml/radical-fallback.html
mathml/opentype/opentype-stretchy.html
mathml/presentation/mspace-children.html
mathml/presentation/menclose-notation-values.html
mathml/presentation/roots.xhtml
mathml/presentation/menclose-notation-default-longdiv.html
Comment 11 Build Bot 2016-07-13 09:32:14 PDT
Created attachment 283538 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.5
Comment 12 Frédéric Wang (:fredw) 2016-07-13 09:51:59 PDT
Created attachment 283539 [details]
Patch
Comment 13 Build Bot 2016-07-13 10:38:26 PDT
Comment on attachment 283539 [details]
Patch

Attachment 283539 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1675146

New failing tests:
mathml/mathml-in-dashboard.html
Comment 14 Build Bot 2016-07-13 10:38:29 PDT
Created attachment 283541 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 15 Build Bot 2016-07-13 10:56:37 PDT
Comment on attachment 283539 [details]
Patch

Attachment 283539 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1675159

New failing tests:
mathml/mathml-in-dashboard.html
Comment 16 Build Bot 2016-07-13 10:56:41 PDT
Created attachment 283546 [details]
Archive of layout-test-results from ews112 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 17 Frédéric Wang (:fredw) 2016-07-13 11:00:54 PDT
Created attachment 283547 [details]
Patch
Comment 18 Frédéric Wang (:fredw) 2016-07-13 11:20:04 PDT
Created attachment 283550 [details]
Patch
Comment 19 Brent Fulgham 2016-07-13 12:10:01 PDT
Comment on attachment 283550 [details]
Patch

This is a small style change with massive re baseline.
Comment 20 Frédéric Wang (:fredw) 2016-07-13 12:15:53 PDT
Committed r203171: <http://trac.webkit.org/changeset/203171>