Bug 157989 – Remove padding and margin around the <math> element

• Status: RESOLVED
• Resolution: FIXED
• Component: MathML

[Frédéric Wang (:fredw)]

Created attachment 279565 [details]
Patch

The MathML user agent stylesheet has some 1px padding on the right/left of the <math> root. This was added a long time ago in

http://trac.webkit.org/changeset/61861/trunk/WebCore/css/mathml.css

but the intention is unclear, probably to tweak the spacing. I don't think that's necessary and it some tests have to revert this change to avoid 1px shifts, so let's remove it and keep the UA stylesheet minimal.

[Manuel Rego Casasnovas]

Comment on attachment 279565 [details]
Patch

Yes sure, let's get rid of it. You'll need a bunch of rebaselines though, also the ChangeLog entry.

[Frédéric Wang (:fredw)]

Created attachment 283528 [details]
Patch

[Frédéric Wang (:fredw)]

The patch does the small CSS change for the <math> tag, remove all the hacks in the reftests and also rebaseline GTK tests. We will have to do the rebaseline for all the ports, though.

[Build Bot]

Comment on attachment 283528 [details]
Patch

Attachment 283528 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1674785

New failing tests:
mathml/opentype/opentype-stretchy-horizontal.html
mathml/presentation/mo-stretch.html
mathml/radical-fallback.html
mathml/opentype/opentype-stretchy.html
mathml/presentation/mspace-children.html
mathml/mathml-in-dashboard.html
mathml/presentation/menclose-notation-values.html
mathml/presentation/roots.xhtml
mathml/presentation/menclose-notation-default-longdiv.html

[Build Bot]

Created attachment 283534 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 283528 [details]
Patch

Attachment 283528 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1674792

New failing tests:
mathml/opentype/opentype-stretchy-horizontal.html
mathml/presentation/mo-stretch.html
mathml/radical-fallback.html
mathml/opentype/opentype-stretchy.html
mathml/presentation/mspace-children.html
mathml/presentation/menclose-notation-values.html
mathml/presentation/roots.xhtml
mathml/presentation/menclose-notation-default-longdiv.html

[Build Bot]

Created attachment 283535 [details]
Archive of layout-test-results from ews106 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 283528 [details]
Patch

Attachment 283528 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1674837

New failing tests:
mathml/opentype/opentype-stretchy-horizontal.html
mathml/presentation/mo-stretch.html
mathml/radical-fallback.html
mathml/opentype/opentype-stretchy.html
mathml/presentation/mspace-children.html
mathml/mathml-in-dashboard.html
mathml/presentation/menclose-notation-values.html
mathml/presentation/roots.xhtml
mathml/presentation/menclose-notation-default-longdiv.html

[Build Bot]

Created attachment 283536 [details]
Archive of layout-test-results from ews112 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 283528 [details]
Patch

Attachment 283528 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1674818

New failing tests:
mathml/opentype/opentype-stretchy-horizontal.html
mathml/presentation/mo-stretch.html
mathml/radical-fallback.html
mathml/opentype/opentype-stretchy.html
mathml/presentation/mspace-children.html
mathml/presentation/menclose-notation-values.html
mathml/presentation/roots.xhtml
mathml/presentation/menclose-notation-default-longdiv.html

[Build Bot]

Created attachment 283538 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.5

[Frédéric Wang (:fredw)]

Created attachment 283539 [details]
Patch

[Build Bot]

Comment on attachment 283539 [details]
Patch

Attachment 283539 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1675146

New failing tests:
mathml/mathml-in-dashboard.html

[Build Bot]

Created attachment 283541 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 283539 [details]
Patch

Attachment 283539 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1675159

New failing tests:
mathml/mathml-in-dashboard.html

[Build Bot]

Created attachment 283546 [details]
Archive of layout-test-results from ews112 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Frédéric Wang (:fredw)]

Created attachment 283547 [details]
Patch

[Frédéric Wang (:fredw)]

Created attachment 283550 [details]
Patch

[Brent Fulgham]

Comment on attachment 283550 [details]
Patch

This is a small style change with massive re baseline.

[Frédéric Wang (:fredw)]

Committed r203171: <http://trac.webkit.org/changeset/203171>