Bug 157988 - Preload single download tests.
Summary: Preload single download tests.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-23 06:18 PDT by Yoav Weiss
Modified: 2016-05-27 06:18 PDT (History)
5 users (show)

See Also:


Attachments
Patch (6.66 KB, patch)
2016-05-23 06:22 PDT, Yoav Weiss
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews123 for ios-simulator-wk2 (688.44 KB, application/zip)
2016-05-23 07:17 PDT, Build Bot
no flags Details
Patch (6.67 KB, patch)
2016-05-26 00:39 PDT, Yoav Weiss
no flags Details | Formatted Diff | Diff
Patch (6.17 KB, patch)
2016-05-26 13:52 PDT, Yoav Weiss
no flags Details | Formatted Diff | Diff
Patch (6.70 KB, patch)
2016-05-26 14:31 PDT, Yoav Weiss
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yoav Weiss 2016-05-23 06:18:11 PDT
Preload single download tests.
Comment 1 Yoav Weiss 2016-05-23 06:22:18 PDT
Created attachment 279563 [details]
Patch
Comment 2 Build Bot 2016-05-23 07:17:36 PDT
Comment on attachment 279563 [details]
Patch

Attachment 279563 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1369482

New failing tests:
http/tests/preload/single_download_preload_runner.html
Comment 3 Build Bot 2016-05-23 07:17:40 PDT
Created attachment 279564 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.4
Comment 4 Yoav Weiss 2016-05-26 00:39:12 PDT
Created attachment 279872 [details]
Patch
Comment 5 Alex Christensen 2016-05-26 09:08:24 PDT
Comment on attachment 279872 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=279872&action=review

> LayoutTests/http/tests/preload/resources/single_download_preload.html:44
> +<span>PASS - this text is here just so that the browser will download the font.</span>

I'm not sure PASS is a good thing to have here.

> LayoutTests/http/tests/preload/single_download_preload_runner.html:13
> +        assert_equals(data, 10);

Is there a way to have this print something to the expectations?  This value is what the test is confirming, and it's hard to tell just by glancing at the test.
Comment 6 Yoav Weiss 2016-05-26 13:52:22 PDT
Created attachment 279908 [details]
Patch
Comment 7 Yoav Weiss 2016-05-26 13:54:33 PDT
(In reply to comment #5)
> Comment on attachment 279872 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=279872&action=review
> 
> > LayoutTests/http/tests/preload/resources/single_download_preload.html:44
> > +<span>PASS - this text is here just so that the browser will download the font.</span>
> 
> I'm not sure PASS is a good thing to have here.

Removed it

> 
> > LayoutTests/http/tests/preload/single_download_preload_runner.html:13
> > +        assert_equals(data, 10);
> 
> Is there a way to have this print something to the expectations?  This value
> is what the test is confirming, and it's hard to tell just by glancing at
> the test.

Actually the expectation is not needed for testharness tests. I deleted it and added a description on the assert. Let me know if it's clear enough.
Comment 8 Yoav Weiss 2016-05-26 14:31:20 PDT
Created attachment 279910 [details]
Patch
Comment 9 Yoav Weiss 2016-05-26 14:32:13 PDT
(In reply to comment #8)
> Created attachment 279910 [details]
> Patch

Turns out expectation was needed on the debug build. Added it back.
Comment 10 WebKit Commit Bot 2016-05-26 22:42:41 PDT
Comment on attachment 279910 [details]
Patch

Clearing flags on attachment: 279910

Committed r201447: <http://trac.webkit.org/changeset/201447>
Comment 11 WebKit Commit Bot 2016-05-26 22:42:46 PDT
All reviewed patches have been landed.  Closing bug.