Bug 157988 – Preload single download tests.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Yoav Weiss]

Preload single download tests.

[Yoav Weiss]

Created attachment 279563 [details]
Patch

[Build Bot]

Comment on attachment 279563 [details]
Patch

Attachment 279563 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1369482

New failing tests:
http/tests/preload/single_download_preload_runner.html

[Build Bot]

Created attachment 279564 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.4

[Yoav Weiss]

Created attachment 279872 [details]
Patch

[Alex Christensen]

Comment on attachment 279872 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=279872&action=review

> LayoutTests/http/tests/preload/resources/single_download_preload.html:44
> +<span>PASS - this text is here just so that the browser will download the font.</span>

I'm not sure PASS is a good thing to have here.

> LayoutTests/http/tests/preload/single_download_preload_runner.html:13
> +        assert_equals(data, 10);

Is there a way to have this print something to the expectations?  This value is what the test is confirming, and it's hard to tell just by glancing at the test.

[Yoav Weiss]

Created attachment 279908 [details]
Patch

[Yoav Weiss]

(In reply to comment #5)
> Comment on attachment 279872 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=279872&action=review
> 
> > LayoutTests/http/tests/preload/resources/single_download_preload.html:44
> > +<span>PASS - this text is here just so that the browser will download the font.</span>
> 
> I'm not sure PASS is a good thing to have here.

Removed it

> 
> > LayoutTests/http/tests/preload/single_download_preload_runner.html:13
> > +        assert_equals(data, 10);
> 
> Is there a way to have this print something to the expectations?  This value
> is what the test is confirming, and it's hard to tell just by glancing at
> the test.

Actually the expectation is not needed for testharness tests. I deleted it and added a description on the assert. Let me know if it's clear enough.

[Yoav Weiss]

Created attachment 279910 [details]
Patch

[Yoav Weiss]

(In reply to comment #8)
> Created attachment 279910 [details]
> Patch

Turns out expectation was needed on the debug build. Added it back.

[WebKit Commit Bot]

Comment on attachment 279910 [details]
Patch

Clearing flags on attachment: 279910

Committed r201447: <http://trac.webkit.org/changeset/201447>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.