This class is basically currently named after a bug. We should never have been binding function to slot bases - this was not ever correct behavior. This was fixed earlier in the year, but there is still some cruft including the class name to clean up.
Created attachment 279554 [details] Fix
Comment on attachment 279554 [details] Fix rs=me if you rebase
I've just landed r201703, it allows this patch to be landed!
Created attachment 281136 [details] Updated patch for EWS
Attachment 281136 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/runtime/JSGlobalObject.cpp:68: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/JavaScriptCore/runtime/JSObject.cpp:40: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/JavaScriptCore/runtime/JSCustomGetterSetterFunction.h:66: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 3 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 281138 [details] Updated patch for EWS
Attachment 281138 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/runtime/JSGlobalObject.cpp:68: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/JavaScriptCore/runtime/JSObject.cpp:40: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/JavaScriptCore/runtime/JSCustomGetterSetterFunction.h:66: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 3 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 281140 [details] Updated patch for EWS
Comment on attachment 281140 [details] Updated patch for EWS Attachment 281140 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/1492234 New failing tests: imported/w3c/web-platform-tests/html/dom/interfaces.html js/dom/native-bindings-descriptors.html js/function-toString-vs-name.html
Created attachment 281141 [details] Archive of layout-test-results from ews103 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 281140 [details] Updated patch for EWS Attachment 281140 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/1492237 New failing tests: imported/w3c/web-platform-tests/html/dom/interfaces.html js/dom/native-bindings-descriptors.html js/function-toString-vs-name.html
Created attachment 281142 [details] Archive of layout-test-results from ews104 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Comment on attachment 281140 [details] Updated patch for EWS Attachment 281140 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/1492229 New failing tests: js/dom/native-bindings-descriptors.html js/function-toString-vs-name.html
Created attachment 281143 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.4
Comment on attachment 281140 [details] Updated patch for EWS Attachment 281140 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/1492240 New failing tests: js/dom/native-bindings-descriptors.html js/function-toString-vs-name.html
Created attachment 281144 [details] Archive of layout-test-results from ews113 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-yosemite Platform: Mac OS X 10.10.5
Created attachment 281161 [details] Updated patch for EWS
Committed revision 202027.