Bug 157971 – [css-grid] Horizontal scroll must account for grid container's height

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Javier Fernandez]

Created attachment 279540 [details]
Test case to reproduce the crash.

It seems grid layout logic does not consider the scrollbar size when computing the grid container's height. 
This may result in an incorrect sizing when using indefinite sized containers.

Besides, it's possible to make the layout logic to crash due to the fact that contentLogicalHeight can be a negative value if we render a case where content size is 0px.

[Javier Fernandez]

Created attachment 279562 [details]
Patch

[Manuel Rego Casasnovas]

Comment on attachment 279562 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=279562&action=review

LGTM.

> LayoutTests/fast/css-grid-layout/grid-container-scroll-accounts-for-sizing-expected.html:7
> +   width: -webkit-fit-content;

Nit: Maybe you can use "css-intrinsic-dimensions/resources/width-keyword-classes.css".

Or simply something like "position: absolute" or "float: left" to force the shrink-to-fit.

[Javier Fernandez]

Created attachment 279672 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 279672 [details]
Patch

Rejecting attachment 279672 [details] from commit-queue.

Number of test failures exceeded the failure limit.
Full output: http://webkit-queues.webkit.org/results/1375984

[WebKit Commit Bot]

Created attachment 279678 [details]
Archive of layout-test-results from webkit-cq-01 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-01  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[WebKit Commit Bot]

Comment on attachment 279672 [details]
Patch

Clearing flags on attachment: 279672

Committed r201709: <http://trac.webkit.org/changeset/201709>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.