REGRESSION(r184899): Ascent adjustments are applied to web fonts
Created attachment 279498 [details] Patch
<rdar://problem/24204349>
Comment on attachment 279498 [details] Patch I don't think we can commit this font file to Open Source. We don't have a license for it. Can we use something else?
Created attachment 279504 [details] Patch
Comment on attachment 279504 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=279504&action=review > LayoutTests/fast/text/resources/Helvetica_light.svg:6 > +<font id="Litherum" horiz-adv-x="1024"> How is this working if the id is Litherum? and the family you use below is "Helvetica".
Comment on attachment 279504 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=279504&action=review >> LayoutTests/fast/text/resources/Helvetica_light.svg:6 >> +<font id="Litherum" horiz-adv-x="1024"> > > How is this working if the id is Litherum? and the family you use below is "Helvetica". The @font-face block doesn't list a fragment identifier, so it will just use the first (or last, I can't remember) font in the file. The font-family below is what the SVG -> OTF converter uses to embed the family name inside the font (and is necessary to trigger the ascent adjustment).
Comment on attachment 279504 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=279504&action=review >> LayoutTests/fast/text/resources/Helvetica_light.svg:6 >> +<font id="Litherum" horiz-adv-x="1024"> > > How is this working if the id is Litherum? and the family you use below is "Helvetica". You should at least remove this id. > LayoutTests/fast/text/resources/Helvetica_light.svg:7 > +<font-face units-per-em="2048" ascent="1577" descent="-471" font-family="Helvetica"/> And change the family name.
Committed r201228: <http://trac.webkit.org/changeset/201228>