Bug 157951 - JSBench regression: CodeBlock linking always copies the symbol table
Summary: JSBench regression: CodeBlock linking always copies the symbol table
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-20 11:53 PDT by Geoffrey Garen
Modified: 2016-05-20 12:12 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.78 KB, patch)
2016-05-20 11:55 PDT, Geoffrey Garen 		saam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2016-05-20 11:53:50 PDT 
JSBench regression: CodeBlock linking always copies the symbol table
Comment 1 Geoffrey Garen 2016-05-20 11:55:46 PDT 
Created attachment 279493 [details]
Patch
Comment 2 Saam Barati 2016-05-20 11:59:05 PDT 
Comment on attachment 279493 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=279493&action=review

r=me

> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:1673
> +        ASSERT(var.symbolTableConstantIndex());

Style: I think its nicer to put asserts validating inputs before we assign something to the input.
Comment 3 Geoffrey Garen 2016-05-20 12:12:00 PDT 
Committed r201221: <http://trac.webkit.org/changeset/201221>