Bug 157950 - Web Inspector: Split console navigation bar doesn't wrap as expected
Summary: Web Inspector: Split console navigation bar doesn't wrap as expected
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
URL:
Keywords: InRadar
: 158102 (view as bug list)
Depends on:
Blocks:
 
Reported: 2016-05-20 11:49 PDT by Nikita Vasilyev
Modified: 2016-05-25 20:30 PDT (History)
8 users (show)

See Also:


Attachments
[Image] Expected (80.57 KB, image/png)
2016-05-20 12:13 PDT, Nikita Vasilyev
no flags Details
[Image] height: 100% (148.31 KB, image/png)
2016-05-23 13:09 PDT, Nikita Vasilyev
no flags Details
Patch (1.26 KB, patch)
2016-05-23 15:23 PDT, Nikita Vasilyev
no flags Details | Formatted Diff | Diff
[Image] With patch applied (91.43 KB, image/png)
2016-05-23 15:23 PDT, Nikita Vasilyev
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2016-05-20 11:49:50 PDT
https://cloudup.com/cguM608RX6x

This is a recent regression.
Comment 1 Radar WebKit Bug Importer 2016-05-20 11:50:32 PDT
<rdar://problem/26395573>
Comment 2 Timothy Hatcher 2016-05-20 12:08:43 PDT
I don't think we ever handled this well. Ideally the scope bar would collapse into a single item like we use for the sidebar filtering at the top. But that does not support multiple selection like the Console filtering does.
Comment 3 Nikita Vasilyev 2016-05-20 12:13:55 PDT
Created attachment 279494 [details]
[Image] Expected

(In reply to comment #2)
> I don't think we ever handled this well. Ideally the scope bar would
> collapse into a single item like we use for the sidebar filtering at the
> top. But that does not support multiple selection like the Console filtering
> does.

This is how it looks in STP.
Comment 4 Timothy Hatcher 2016-05-20 12:23:47 PDT
I think we were just loosing items off the end as they ran out of room. Not really ideal, but not obviously broken like it is right now. My change yesterday might have broken this.

http://trac.webkit.org/changeset/201177/trunk/Source/WebInspectorUI/UserInterface/Views/NavigationBar.css
Comment 5 Nikita Vasilyev 2016-05-20 14:25:44 PDT
(In reply to comment #4)
> I think we were just loosing items off the end as they ran out of room. Not
> really ideal, but not obviously broken like it is right now. My change
> yesterday might have broken this.
> 
> http://trac.webkit.org/changeset/201177/trunk/Source/WebInspectorUI/
> UserInterface/Views/NavigationBar.css

Yes, that change broke it.

I'm thinking of a better solution.
Comment 6 Timothy Hatcher 2016-05-20 16:48:08 PDT
Does height: 100% work? I tested it but settled on auto for my change. Maybe there is a difference.
Comment 7 Nikita Vasilyev 2016-05-23 13:09:23 PDT
Created attachment 279581 [details]
[Image] height: 100%

(In reply to comment #6)
> Does height: 100% work? I tested it but settled on auto for my change. Maybe
> there is a difference.

It works fine for the split console, but it has issues elsewhere.
Comment 8 Nikita Vasilyev 2016-05-23 15:23:09 PDT
Created attachment 279590 [details]
Patch
Comment 9 Nikita Vasilyev 2016-05-23 15:23:54 PDT
Created attachment 279591 [details]
[Image] With patch applied
Comment 10 WebKit Commit Bot 2016-05-23 16:32:06 PDT
Comment on attachment 279590 [details]
Patch

Clearing flags on attachment: 279590

Committed r201304: <http://trac.webkit.org/changeset/201304>
Comment 11 WebKit Commit Bot 2016-05-23 16:32:10 PDT
All reviewed patches have been landed.  Closing bug.
Comment 12 Joseph Pecoraro 2016-05-25 20:30:04 PDT
*** Bug 158102 has been marked as a duplicate of this bug. ***