WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED WONTFIX
15795
[GTK] Change the mouse pointer state to busy while loading a page
https://bugs.webkit.org/show_bug.cgi?id=15795
Summary
[GTK] Change the mouse pointer state to busy while loading a page
Salvatore De Paolis
Reported
2007-11-02 07:59:26 PDT
It would be nice if the webkit_open_page could set the mouse pointer to busy while loading a page.
Attachments
useloadingcursor.diff
(4.93 KB, patch)
2008-02-02 15:58 PST
,
Xan Lopez
no flags
Details
Formatted Diff
Diff
Patch
(1.94 KB, patch)
2014-02-27 03:11 PST
,
Diego Pino
pnormand
: review-
pnormand
: commit-queue-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Jan Alonzo
Comment 1
2007-12-01 00:59:58 PST
This is a duplicate of bug
http://bugs.webkit.org/show_bug.cgi?id=16205
Mark Rowe (bdash)
Comment 2
2007-12-01 01:08:49 PST
***
Bug 16205
has been marked as a duplicate of this bug. ***
Xan Lopez
Comment 3
2008-01-22 10:48:05 PST
So, bdash told me yesterday that WebKit does not do this (and has never done it). If it should be done on Application side this bug should be closed as INVALID/WONTFIX.
Christian Dywan
Comment 4
2008-01-23 01:44:48 PST
Unlike for example gtkmozembed WebKit does not normally apply a loading pointer on its own. In many non-browser use cases this is the desired behavior. Instead you should make use of gdk_window_set_cursor in a "load-progress-changed" callback.
Xan Lopez
Comment 5
2008-01-26 08:34:07 PST
BTW: while I don't have anything against doing this in app-side, we need some API hooks to do it correctly I think. Unconditionally setting cursor on load-progress-changed is wrong: if you are hovering a link, for example, the cursor should remain as a "hand" all the time, but we'd switch it to a "watch/wait" when the next progress-change happens.A signal would a good way of doing this, but any other way would do. Or if anybody knows how Safari or other WebKit browser handles this, that might help too :)
Alp Toker
Comment 6
2008-02-02 14:21:35 PST
Yeah, I think it's OK for us to support this in WebCore directly, though it might be worth providing a way to turn it off. Xan, can you try adding a setPointerCursor() (or maybe pushPointerCursor()/pop if you're feeling elaborate) to Cursor.h? Then we can just call this from somewhere doing the loading.
Xan Lopez
Comment 7
2008-02-02 15:58:36 PST
Created
attachment 18875
[details]
useloadingcursor.diff Quick and dirty patch. - I'm using just a bool value in CursorGtk to decide if I return pointerCursor or waitCursor in the pointerCursor function. I think this is good enough? The static variable might be anathema in C++, maybe we can replace it with some class variable or something...? - Might want to cache the value of the setting in FrameLoaderClientGtk and connect to notify::use-loading-cursor to update the value. Tested this with Epiphany, it works ok.
Jan Alonzo
Comment 8
2009-06-20 19:36:18 PDT
***
Bug 26579
has been marked as a duplicate of this bug. ***
Evan Martin
Comment 9
2010-01-10 19:24:49 PST
Found this old bug. In Chrome we have to do some work to get the cursor+hourglass cursor that Firefox (and now Chrome) uses. You can take a glance through the Chrome cursor code to see how it works. (It's pretty hacky.)
Diego Pino
Comment 10
2014-02-27 03:11:46 PST
Created
attachment 225352
[details]
Patch
Philippe Normand
Comment 11
2014-03-16 03:58:07 PDT
Comment on
attachment 225352
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=225352&action=review
> Tools/MiniBrowser/gtk/BrowserWindow.c:485 > + GdkWindow *gdk_window = gtk_widget_get_window(GTK_WIDGET(window->webView));
We use camelCase here, I think. So, gdkWindow ?
> Tools/MiniBrowser/gtk/BrowserWindow.c:493 > + gdk_window_set_cursor(gdk_window, lastCursor);
I suppose it's alright to not check lastCursor is non-null here, right? Passing NULL means use the cursor of the parent window.
Martin Robinson
Comment 12
2015-05-07 16:18:20 PDT
Pretty sure we don't want this ATM.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug