WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
157943
Small improvements to RenderBox/LayoutUnit casting in MathML
https://bugs.webkit.org/show_bug.cgi?id=157943
Summary
Small improvements to RenderBox/LayoutUnit casting in MathML
Frédéric Wang (:fredw)
Reported
2016-05-20 06:16:18 PDT
This is a small follow-up of the RenderMathMLRow/RenderMathMLUnderOver/RenderMathMLFraction refactoring. Since these MathML renderers can only contain other MathML renderers, we can just considerer RenderBox children and prevent unnecessary casts. Similarly, when the two arguments of std::max are LayoutUnit's, we do not need to specialize to std::max<LayoutUnit>.
Attachments
Patch
(5.97 KB, patch)
2016-05-20 06:23 PDT
,
Frédéric Wang (:fredw)
darin
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Frédéric Wang (:fredw)
Comment 1
2016-05-20 06:23:50 PDT
Created
attachment 279480
[details]
Patch
Darin Adler
Comment 2
2016-05-24 09:03:02 PDT
Comment on
attachment 279480
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=279480&action=review
> Source/WebCore/rendering/mathml/RenderMathMLUnderOver.cpp:58 > + RenderBox* base = firstChildBox();
Typically in new code, we would use auto* here instead of writing RenderBox*.
> Source/WebCore/rendering/mathml/RenderMathMLUnderOver.cpp:78 > + for (RenderBox* child = firstChildBox(); child; child = child->nextSiblingBox()) {
Ditto.
Frédéric Wang (:fredw)
Comment 3
2016-05-26 02:16:18 PDT
https://trac.webkit.org/changeset/201418
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug