Bug 157934 – Web Inspector: Right-clicking in Snapshot's DataGrid throws an exception

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Nikita Vasilyev]

Created attachment 279449 [details]
[Animated GIF] Bug

[Error] TypeError: null is not an object (evaluating 'cell.classList')
	isEventWithinDisclosureTriangle (DataGrid.js:2465)
	_clickInDataTable (DataGrid.js:1593)
	_clickInDataTable

[Radar WebKit Bug Importer]

<rdar://problem/26380910>

[Blaze Burg]

I wasn't able to reproduce this.

In the future, please write down reproduction steps in addition to adding animated gifs. Often, the GIFs are not conclusive or do not show the user inputs or input timing requirements.

If you file such bugs using the built-in Uncaught Exception reporter, places for these details will already exist in the bug template.

[Matt Baker]

* STEPS TO REPRODUCE:
1. Start and stop a recording. Two snapshots are created.
2. Select one of the snapshots.
3. In the Class Name column, right-click any disclosure triangle.
  => TypeError:​ null is not an object (evaluating 'cell.classList')​ (at DataGrid.js:​2469:​18)​

[Matt Baker]

Looks like this affects all of our data grids.

[Matt Baker]

Revised:

* STEPS TO REPRODUCE:
1. Start and stop a Timeline recording.
2. Select any timeline with nested grid rows. 
3. Right-click a disclosure triangle. Doesn't matter if the row is selected or not.
4. Dismiss popup with ESCAPE.
  => Nothing happens
5. Dismiss popup by clicking a cell in the same row, but a different column.
  => TypeError:​ null is not an object (evaluating 'cell.classList')​ (at DataGrid.js:​2469:​18)​

[Matt Baker]

> 3. Right-click a disclosure triangle. Doesn't matter if the row is selected
> or not.

Also the row has to have been expanded. Doesn't matter if it is expanded when dismissing the popup, as long as it was expanded at least once in the past.

[Matt Baker]

Fix coming.

[Matt Baker]

Created attachment 280065 [details]
[Patch] Proposed Fix

[Blaze Burg]

(In reply to comment #5)
> Revised:
> 
> * STEPS TO REPRODUCE:
> 1. Start and stop a Timeline recording.
> 2. Select any timeline with nested grid rows. 
> 3. Right-click a disclosure triangle. Doesn't matter if the row is selected
> or not.
> 4. Dismiss popup with ESCAPE.
>   => Nothing happens
> 5. Dismiss popup by clicking a cell in the same row, but a different column.
>   => TypeError:​ null is not an object (evaluating 'cell.classList')​ (at
> DataGrid.js:​2469:​18)​

This is great.

[Blaze Burg]

Comment on attachment 280065 [details]
[Patch] Proposed Fix

r=me

[WebKit Commit Bot]

Comment on attachment 280065 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 280065

Committed r201499: <http://trac.webkit.org/changeset/201499>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.