Bug 157932 - Web Inspector: Visual Style connectors are not always centered properly
Summary: Web Inspector: Visual Style connectors are not always centered properly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-05-19 16:32 PDT by Joseph Pecoraro
Modified: 2016-05-19 21:12 PDT (History)
10 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (2.15 KB, patch)
2016-05-19 16:34 PDT, Joseph Pecoraro 		timothy: review+
Details | Formatted Diff | Diff
[IMAGE] Before (28.27 KB, image/png)
2016-05-19 16:36 PDT, Joseph Pecoraro 		no flags Details
[IMAGE] After (28.06 KB, image/png)
2016-05-19 16:37 PDT, Joseph Pecoraro 		no flags Details
[PATCH] Proposed Fix (2.16 KB, patch)
2016-05-19 17:06 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2016-05-19 16:32:07 PDT 
* SUMMARY
Visual Style connectors are not always centered properly.

- All the time, the top and bottom connectors are different distances from the center connector
- At some widths, the middle connector is off-center from the others
Comment 1 Radar WebKit Bug Importer 2016-05-19 16:33:00 PDT 
<rdar://problem/26380629>
Comment 2 Joseph Pecoraro 2016-05-19 16:34:18 PDT 
Created attachment 279446 [details]
[PATCH] Proposed Fix
Comment 3 Joseph Pecoraro 2016-05-19 16:36:36 PDT 
Created attachment 279447 [details]
[IMAGE] Before
Comment 4 Joseph Pecoraro 2016-05-19 16:37:05 PDT 
Created attachment 279448 [details]
[IMAGE] After
Comment 5 Joseph Pecoraro 2016-05-19 16:40:16 PDT 
Comment on attachment 279446 [details]
[PATCH] Proposed Fix

The margin-left: 1px may be needed for non-Retina.
Comment 6 Joseph Pecoraro 2016-05-19 17:06:11 PDT 
Created attachment 279455 [details]
[PATCH] Proposed Fix

Tested on @1x and @2x.
Comment 7 WebKit Commit Bot 2016-05-19 21:12:31 PDT 
Comment on attachment 279455 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 279455

Committed r201209: <http://trac.webkit.org/changeset/201209>
Comment 8 WebKit Commit Bot 2016-05-19 21:12:36 PDT 
All reviewed patches have been landed.  Closing bug.