Bug 157910 - Web Inspector: Split Console is auto opening all the time when using Inspect Element context menu
Summary: Web Inspector: Split Console is auto opening all the time when using Inspect ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-05-19 12:20 PDT by Timothy Hatcher
Modified: 2016-05-20 12:35 PDT (History)
8 users (show)

See Also:


Attachments
Patch (1.90 KB, patch)
2016-05-19 15:06 PDT, Nikita Vasilyev
timothy: review+
Details | Formatted Diff | Diff
Patch (9.97 KB, patch)
2016-05-20 11:40 PDT, Nikita Vasilyev
no flags Details | Formatted Diff | Diff
Patch (10.07 KB, patch)
2016-05-20 11:42 PDT, Nikita Vasilyev
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2016-05-19 12:20:43 PDT
This might be happening because the Inspected Element auto logging? It is getting annoying!
Comment 1 Radar WebKit Bug Importer 2016-05-19 12:24:53 PDT
<rdar://problem/26374066>
Comment 2 Nikita Vasilyev 2016-05-19 15:06:08 PDT
Created attachment 279438 [details]
Patch
Comment 3 Timothy Hatcher 2016-05-19 15:08:59 PDT
Comment on attachment 279438 [details]
Patch

I think this will cause the split console to not open for things like "Log Object" in the heap snapshot. Joe?
Comment 4 Joseph Pecoraro 2016-05-19 15:28:28 PDT
Comment on attachment 279438 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=279438&action=review

> Source/WebInspectorUI/UserInterface/Controllers/JavaScriptLogViewController.js:273
>          // We only auto show the console if the message is a non-synthetic result.
>          // This is when the user evaluated something directly in the prompt.

Right now "synthetic" means "token". It does not mean frontend added.

If we want to distinguish between frontend added immediately evaluations (Log Value and Inspect Element) you would want a new state to work with.
Comment 5 Nikita Vasilyev 2016-05-20 11:40:51 PDT
Created attachment 279491 [details]
Patch
Comment 6 Nikita Vasilyev 2016-05-20 11:42:12 PDT
Created attachment 279492 [details]
Patch
Comment 7 WebKit Commit Bot 2016-05-20 12:34:59 PDT
Comment on attachment 279492 [details]
Patch

Clearing flags on attachment: 279492

Committed r201222: <http://trac.webkit.org/changeset/201222>
Comment 8 WebKit Commit Bot 2016-05-20 12:35:03 PDT
All reviewed patches have been landed.  Closing bug.