Bug 157904 – Web Inspector: Snapshot List should show the total size and the total live size

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

* SUMMARY
Snapshot List should show the total size and the total live size.

As objects go away, it would be nice to show just the total live size, so you can see just the growth.

[Radar WebKit Bug Importer]

<rdar://problem/26372833>

[Joseph Pecoraro]

Created attachment 281684 [details]
[PATCH] Proposed Fix

[Joseph Pecoraro]

Created attachment 281685 [details]
[IMAGE] Live Size Column

Example page doesn't really leak, it just creates a lot of objects in between takeHeapSnapshot("before") and "after" that will get collected. The "after" correctly shows lots of objects, but after they get collected and another snapshot is taken, the live size updates.

[Blaze Burg]

Comment on attachment 281684 [details]
[PATCH] Proposed Fix

r=me

[Blaze Burg]

(In reply to comment #3)
> Created attachment 281685 [details]
> [IMAGE] Live Size Column
> 
> Example page doesn't really leak, it just creates a lot of objects in
> between takeHeapSnapshot("before") and "after" that will get collected. The
> "after" correctly shows lots of objects, but after they get collected and
> another snapshot is taken, the live size updates.

This would be a big improvement for the WWDC demo, where it's not entirely clear what portion of the snapshot size growth is actually leak vs. slow churn of large objects.

[WebKit Commit Bot]

Comment on attachment 281684 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 281684

Committed r202253: <http://trac.webkit.org/changeset/202253>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Alexey Proskuryakov]

This broke a test:

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=inspector%2Funit-tests%2Fheap-snapshot-collection-event.html

+!! EXCEPTION: snapshot.updateCategories is not a function. (In 'snapshot.updateCategories', 'snapshot.updateCategories' is undefined)

Both this test and inspector/unit-tests/heap-snapshot.html were already very flaky, but this was definitely a regression.

[WebKit Commit Bot]

Re-opened since this is blocked by bug 158973

[Joseph Pecoraro]

(In reply to comment #9)
> Re-opened since this is blocked by bug 158973

Closing, since we fixed the test instead of rolling out.
<https://trac.webkit.org/changeset/202264>