http://trac.webkit.org/changeset/199649 updated gst-libac from 1.4 to 1.6, we need one more similar fix as http://trac.webkit.org/changeset/174005
Created attachment 279385 [details] Patch
Comment on attachment 279385 [details] Patch Attachment 279385 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/1348143 Number of test failures exceeded the failure limit.
Created attachment 279386 [details] Archive of layout-test-results from ews103 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 279385 [details] Patch Mac EWS is flakey ...
Comment on attachment 279385 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=279385&action=review Hi Ossy. I trust you that this fixes the problem, so r+. > Tools/efl/patches/gst-libav.patch:17 > ++ it eq One request: if the patch was found on the internet, I think it is a good idea to add a link/reference to it in the commit message. Maybe this is fixed in later versions of libav, not sure. Otherwise, if it is authored by you, it is also good to add to the commit message a link to the upstream contribution to libav (if any).
Comment on attachment 279385 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=279385&action=review > Tools/ChangeLog:1 > 2016-05-19 Csaba Osztrogonác <ossy@webkit.org> minor: I see strange characters in your name.
(In reply to comment #5) > Comment on attachment 279385 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=279385&action=review > > Hi Ossy. I trust you that this fixes the problem, so r+. > > > Tools/efl/patches/gst-libav.patch:17 > > ++ it eq > > One request: if the patch was found on the internet, I think it is a good > idea to add a link/reference to it in the commit message. > Maybe this is fixed in later versions of libav, not sure. > > Otherwise, if it is authored by you, it is also good to add to the commit > message a link to the upstream contribution to libav (if any). It is my fix similar to http://trac.webkit.org/changeset/174005 . It seems these bugs aren't fixed in upstream, but unfortunately I don't have time to learn how to contribute to libav, it seems too complex at first sight. :( If there is anybody interested in it, feel free to do it. :) (In reply to comment #6) > Comment on attachment 279385 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=279385&action=review > > > Tools/ChangeLog:1 > > 2016-05-19 Csaba Osztrogonác <ossy@webkit.org> > > minor: I see strange characters in your name. It's normal, pretty-diff can't handle utf8 characters, like "á" in my name, but the commit log and the changelog will be good. :)
Comment on attachment 279385 [details] Patch Clearing flags on attachment: 279385 Committed r201169: <http://trac.webkit.org/changeset/201169>
All reviewed patches have been landed. Closing bug.