Bug 157888 - Suppress -Wmissing-field-initializers warnings with GCC 4.9
Summary: Suppress -Wmissing-field-initializers warnings with GCC 4.9
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Csaba Osztrogonác
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-19 04:32 PDT by Csaba Osztrogonác
Modified: 2016-05-22 03:57 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.59 KB, patch)
2016-05-19 04:34 PDT, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews122 for ios-simulator-wk2 (635.54 KB, application/zip)
2016-05-19 05:39 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2016-05-19 04:32:38 PDT
There are many build failures with GCC 4.9, because this GCC version is buggy
and reports false positive warnings for empty initializer lists:

DerivedSources/WebCore/JSIDBObjectStore.cpp: In function 'T WebCore::convert(JSC::ExecState&, JSC::JSValue) [with T = WebCore::IDBObjectStore::IndexParameters]':
DerivedSources/WebCore/JSIDBObjectStore.cpp:55:18: error: missing initializer for member 'WebCore::IDBObjectStore::IndexParameters::unique' [-Werror=missing-field-initializers]
DerivedSources/WebCore/JSIDBObjectStore.cpp:55:18: error: missing initializer for member 'WebCore::IDBObjectStore::IndexParameters::multiEntry' [-Werror=missing-field-initializers]
DerivedSources/WebCore/JSIDBObjectStore.cpp:59:18: error: missing initializer for member 'WebCore::IDBObjectStore::IndexParameters::unique' [-Werror=missing-field-initializers]
DerivedSources/WebCore/JSIDBObjectStore.cpp:59:18: error: missing initializer for member 'WebCore::IDBObjectStore::IndexParameters::multiEntry' [-Werror=missing-field-initializers]
cc1plus: all warnings being treated as errors

DerivedSources/WebCore/JSFontFace.cpp: In function 'T WebCore::convert(JSC::ExecState&, JSC::JSValue) [with T = WebCore::FontFace::Descriptors]':
DerivedSources/WebCore/JSFontFace.cpp:100:18: error: missing initializer for member 'WebCore::FontFace::Descriptors::style' [-Werror=missing-field-initializers]
DerivedSources/WebCore/JSFontFace.cpp:100:18: error: missing initializer for member 'WebCore::FontFace::Descriptors::weight' [-Werror=missing-field-initializers]
...

DerivedSources/WebCore/JSElement.cpp: In function 'T WebCore::convert(JSC::ExecState&, JSC::JSValue) [with T = WebCore::Element::ShadowRootInit]':
DerivedSources/WebCore/JSElement.cpp:119:18: error: missing initializer for member 'WebCore::Element::ShadowRootInit::mode' [-Werror=missing-field-initializers]
cc1plus: all warnings being treated as errors

DerivedSources/WebCore/JSMutationObserver.cpp: In function 'T WebCore::convert(JSC::ExecState&, JSC::JSValue) [with T = WebCore::MutationObserver::Init]':
DerivedSources/WebCore/JSMutationObserver.cpp:47:18: error: missing initializer for member 'WebCore::MutationObserver::Init::childList' [-Werror=missing-field-initializers]
DerivedSources/WebCore/JSMutationObserver.cpp:47:18: error: missing initializer for member 'WebCore::MutationObserver::Init::attributes' [-Werror=missing-field-initializers]
...

I think the easiest way to fix these build failures is suppressing this warning with GCC 4.9
Comment 1 Csaba Osztrogonác 2016-05-19 04:34:00 PDT
Created attachment 279380 [details]
Patch
Comment 2 Csaba Osztrogonác 2016-05-19 04:36:16 PDT
forgot to mention the GCC bug report: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=36750
Comment 3 Build Bot 2016-05-19 05:39:18 PDT
Comment on attachment 279380 [details]
Patch

Attachment 279380 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1347827

New failing tests:
fast/scrolling/ios/scrollTo-at-page-load.html
Comment 4 Build Bot 2016-05-19 05:39:20 PDT
Created attachment 279383 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.4
Comment 5 Csaba Osztrogonác 2016-05-19 05:43:59 PDT
Comment on attachment 279380 [details]
Patch

ios tester is flakey ...
Comment 6 WebKit Commit Bot 2016-05-22 03:57:08 PDT
Comment on attachment 279380 [details]
Patch

Clearing flags on attachment: 279380

Committed r201247: <http://trac.webkit.org/changeset/201247>
Comment 7 WebKit Commit Bot 2016-05-22 03:57:12 PDT
All reviewed patches have been landed.  Closing bug.