Bug 157887 – Fix the build with GCC 4.9 in CSSParser.cpp after r200626

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Csaba Osztrogonác]

../../Source/WebCore/css/CSSParser.cpp: In member function 'WTF::Ref<WebCore::StyleRuleBase> WebCore::CSSParser::createViewportRule()':
../../Source/WebCore/css/CSSParser.cpp:13468:12: error: use of deleted function 'WTF::Ref<T>::Ref(const WTF::Ref<U>&) [with U = WebCore::StyleRuleViewport; T = WebCore::StyleRuleBase]'
In file included from ../../Source/WTF/wtf/PassRefPtr.h:25:0,
                 from ../../Source/WTF/wtf/RefPtr.h:30,
                 from ../../Source/WTF/wtf/HashFunctions.h:26,
                 from DerivedSources/WebCore/CSSPropertyNames.h:7,
                 from ../../Source/WebCore/css/CSSPrimitiveValue.h:24,
                 from ../../Source/WebCore/css/CSSCalculationValue.h:33,
                 from ../../Source/WebCore/css/CSSParser.h:25,
                 from ../../Source/WebCore/css/CSSParser.cpp:29:
../../Source/WTF/wtf/Ref.h:69:26: note: declared here

[Csaba Osztrogonác]

Created attachment 279377 [details]
Patch

[Csaba Osztrogonác]

Just to document, the following change broke the build:
http://trac.webkit.org/changeset/200626/trunk/Source/WebCore/css/CSSParser.cpp

[Chris Dumez]

Comment on attachment 279377 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=279377&action=review

> Source/WebCore/css/CSSParser.cpp:13460
>  {

I would prefer if we updated this method to return a Ref<StyleRuleViewport> instead.

[Csaba Osztrogonác]

Created attachment 279396 [details]
Patch

speculative fix without time to build locally , let the EWS to try to build

[Chris Dumez]

Comment on attachment 279396 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=279396&action=review

> Source/WebCore/css/CSSParser.cpp:13463
> +    Ref<StyleRuleViewport> rule = StyleRuleViewport::create(createStyleProperties());

Should use auto

[Chris Dumez]

Comment on attachment 279396 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=279396&action=review

> Source/WebCore/css/CSSParser.cpp:13459
> +Ref<StyleRuleViewport> CSSParser::createViewportRule()

You also need to update the declaration in the header?

[Csaba Osztrogonác]

Created attachment 279398 [details]
Patch

speculative fix without time to build locally , let the EWS to try to build

[Chris Dumez]

Comment on attachment 279398 [details]
Patch

=me

[Chris Dumez]

Unfortunately does not build yet:
../../Source/WebCore/css/CSSParser.h:465:9: error: 'StyleRuleViewport' was not declared in this scope
     Ref<StyleRuleViewport> createViewportRule();

[Csaba Osztrogonác]

Created attachment 279401 [details]
Patch

Patch for landing with EFL buildfix. Tested GCC 4.9 too, it is happy now.

[Chris Dumez]

Comment on attachment 279401 [details]
Patch

lgtm

[Build Bot]

Comment on attachment 279401 [details]
Patch

Attachment 279401 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1349104

New failing tests:
inspector/debugger/scriptParsed.html

[Build Bot]

Created attachment 279404 [details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[WebKit Commit Bot]

Comment on attachment 279401 [details]
Patch

Clearing flags on attachment: 279401

Committed r201173: <http://trac.webkit.org/changeset/201173>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.